[CORE][VL] Handle exception in Schema validation for unsupported join types#11387
Merged
liuneng1994 merged 4 commits intoapache:mainfrom Jan 14, 2026
Merged
[CORE][VL] Handle exception in Schema validation for unsupported join types#11387liuneng1994 merged 4 commits intoapache:mainfrom
liuneng1994 merged 4 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
Surbhi-Vijay
changed the title
Contributor
Author
|
Yohahaha
approved these changes
Jan 12, 2026
Yohahaha
reviewed
Jan 12, 2026
| // LeftSingle join in BroadcastHashJoinExecTransformer. | ||
| ValidationResult.failed( | ||
| s"Failed to retrieve schema for ${this.nodeName}, due to: ${e.getMessage}") | ||
| } |
Contributor
There was a problem hiding this comment.
Should we match Exception to avoid more special case? maybe IllegalArgumentException will be throw in somewhere else.
Contributor
Author
There was a problem hiding this comment.
Do you mean matching the exception message or changing the exception itself?
Contributor
Author
There was a problem hiding this comment.
I think it should be okay to check IllegalArgumentException. We are catching this exception during validation phase and even if the validation is failing at some other place than joins, it should fallback to Spark.
Yohahaha
changed the title
Yohahaha
changed the title
|
Run Gluten Clickhouse CI on x86 |
zhli1142015
approved these changes
Jan 12, 2026
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
Surbhi-Vijay
force-pushed
the
FixJoinValidation
branch
from
04ee646 to
bdf78de
Compare
|
Run Gluten Clickhouse CI on x86 |
Surbhi-Vijay
force-pushed
the
FixJoinValidation
branch
from
bdf78de to
76cd998
Compare
|
Run Gluten Clickhouse CI on x86 |
yaooqinn
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Schema validation fails during validation phase for unsupported join types. When an unsupported join type is encountered, it throws
IllegalArgumentException. This patch catches the exception and adds validation failure msg. This helps in falling back unsupported join type to Spark and query successfully completes.This issue was encountered with Spark-4.0 where new join type
LeftSinglehas been introduced.See: #11372
How was this patch tested?
Tested locally by running spark testcase with native session enabled.