[VL] Allow calling TaskResources.runUnsafe in Spark task code#11405
Merged
zhztheplayer merged 1 commit intoapache:mainfrom Jan 16, 2026
Merged
[VL] Allow calling TaskResources.runUnsafe in Spark task code#11405zhztheplayer merged 1 commit intoapache:mainfrom
zhztheplayer merged 1 commit intoapache:mainfrom
Conversation
The purpose of `TaskResources.runUnsafe` is to prevent driver side code from leaking resources. It's safe to allow the usage in Spark task, so we could reuse some driver-only code (e.g., rule application) in task as well.
|
Run Gluten Clickhouse CI on x86 |
marin-ma
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of
TaskResources.runUnsafeis to prevent driver side code from leaking resources. It's safe to allow the usage in Spark task, so we could reuse some driver-only code (e.g., rule application) in task as well.The patch is to change the code to safely loose the restriction.