[GLUTEN-11390][VL] Align aarch64 compiler flags with Velox to fix xsimd initialization errors#11457
[GLUTEN-11390][VL] Align aarch64 compiler flags with Velox to fix xsimd initialization errors#11457zhouyuan merged 2 commits intoapache:mainfrom
Conversation
…md initialization errors
|
@PHILO-HE PTAL |
dev/build-helper-functions.sh
Outdated
| "aarch64") | ||
| echo -n "-mcpu=neoverse-n1 -std=c++20 $ADDITIONAL_FLAGS" | ||
| # Follow Velox's ARM CPU detection logic to ensure consistent compiler flags | ||
| # between Gluten and Velox, preventing xsimd initialization issues. |
There was a problem hiding this comment.
Suggest adding the issue to make it clear to developers.
preventing xsimd initialization issues, see GLUTEN-11390.
dev/build-helper-functions.sh
Outdated
| echo -n "-mcpu=neoverse-n1 -std=c++20 $ADDITIONAL_FLAGS" | ||
| # Follow Velox's ARM CPU detection logic to ensure consistent compiler flags | ||
| # between Gluten and Velox, preventing xsimd initialization issues. | ||
| # See: ep/build-velox/build/velox_ep/scripts/setup-helper-functions.sh:142-180 |
There was a problem hiding this comment.
Nit: The line numbers can be invalid very likely during Velox's iteration. Suggest the following comment.
Reference: function get_cxx_flags in Velox's setup-helper-functions.sh.
There was a problem hiding this comment.
indeed, I'll modify it.
|
|
@zhouyuan gluten have specific functions like setup_macos/setup_linux that aren't in Velox's version, and velox's get_cxx_flags returns only base flags (e.g., -mcpu=neoverse-n1) without these additional flags. |
3 participants
What changes are proposed in this pull request?
fix: #11390
Follow Velox's ARM CPU detection logic to ensure consistent compiler flags, between Gluten and Velox, preventing xsimd initialization issues.See: ep/build-velox/build/velox_ep/scripts/setup-helper-functions.sh:142-180
How was this patch tested?
build test