Fix window to aggregate conversion with ordering expression validation#11523
Open
lgbo-ustc wants to merge 1 commit intoapache:mainfrom
Open
Fix window to aggregate conversion with ordering expression validation#11523lgbo-ustc wants to merge 1 commit intoapache:mainfrom
lgbo-ustc wants to merge 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
Contributor
Author
|
Run Gluten Clickhouse CI on x86 |
- Add hasOrderExpression method to validate that ordering expressions are not in partition spec - Include additional test case for window function with row_number over multiple partition columns - Prevents incorrect window to aggregate conversion when order expressions don't match partition spec
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
How was this patch tested?
tested by UTs
Was this patch authored or co-authored using generative AI tooling?
No