Skip to content

[VL] Add comprehensive collect_list tests for type coverage and fallback#11526

Closed
yaooqinn wants to merge 2 commits into
apache:mainfrom
yaooqinn:feature/collect-list-tests
Closed

[VL] Add comprehensive collect_list tests for type coverage and fallback#11526
yaooqinn wants to merge 2 commits into
apache:mainfrom
yaooqinn:feature/collect-list-tests

Conversation

@yaooqinn
Copy link
Copy Markdown
Member

What changes are proposed in this pull request?

Add comprehensive test coverage for collect_list aggregate function in VeloxAggregateFunctionsSuite.

New Tests:

  1. collect_list with different primitive types - Tests Boolean, Byte, Short, Int, Long, Float, Double, Decimal, String, Date, Timestamp, Binary types and null handling
  2. collect_list with nested complex types - Tests Array, Struct, and Map types
  3. collect_list with large result sets - Tests performance with 1000 elements
  4. collect_list global aggregation without group by - Tests global aggregation and empty table scenarios
  5. collect_list fallback for unsupported types - Tests TimestampNTZ with explicit fallback verification

How was this patch tested?

  • Code compiles successfully with spotless formatting applied
  • Tests follow existing patterns in VeloxAggregateFunctionsSuite
  • Fallback test explicitly verifies no HashAggregateExecTransformer is present for unsupported types

Was this patch authored or co-authored using generative AI tooling?

Generated-by: GitHub Copilot (Claude)

@github-actions github-actions Bot added the VELOX label Jan 30, 2026
@yaooqinn yaooqinn force-pushed the feature/collect-list-tests branch 5 times, most recently from 2183c63 to b3ca1a2 Compare January 30, 2026 13:53
Add tests for collect_list aggregate function:
- collect_list with different primitive types (Boolean, Byte, Short, Int, Long, Float, Double, Decimal, String, Date, Timestamp, Binary)
- collect_list with nested complex types (Array, Struct, Map)
- collect_list with large result sets (1000 elements)
- collect_list global aggregation without GROUP BY
- collect_list fallback for unsupported types (TimestampNTZ) with explicit verification
@yaooqinn yaooqinn force-pushed the feature/collect-list-tests branch from 3ba4a6a to fdb16cf Compare February 3, 2026 03:56
@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the stale stale label Mar 21, 2026
@github-actions github-actions Bot removed the stale stale label Mar 28, 2026
@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the stale stale label May 12, 2026
@github-actions
Copy link
Copy Markdown

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

@github-actions github-actions Bot closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant