[GLUTEN-11630][VL] Enable iceberg tests#11641
[GLUTEN-11630][VL] Enable iceberg tests#11641jinchengchenghh wants to merge 5 commits intoapache:mainfrom
Conversation
fff0b6b to
978a3b9
Compare
|
Could you help find what should I update for the enhanced feature, I have not update the write @PingLiuPing https://github.com/apache/incubator-gluten/blob/main/cpp/velox/compute/iceberg/IcebergWriter.cc |
To use IBM/velox, you don't need to change anything, most of the PRs from upstream velox have been reverted. |
|
Some revert may have issues, the test with Enhanced feature failed, looks like read delete does not make effect |
|
Hi, @zhouyuan , can we merge this PR first and wait @PingLiuPing to resolve the enhanced feature IBM branch? |
| std::make_shared<velox::connector::hive::HiveConnector>(kHiveConnectorId, hiveConf, ioExecutor_.get())); | ||
|
|
||
| IcebergConnectorFactory icebergFactory; | ||
| auto icebergConnector = icebergFactory.newConnector( |
There was a problem hiding this comment.
If the IcebergConnectorFactory is reverted, this PR cannot compile successfully CC @PingLiuPing
|
Cc: @infvg |
This PR adds IcebergConnector to adapt to Velox refactor.
Temporarily drop iceberg test in enhanced features because of the native code bug, waiting for fix.
Related issue: #11630