[GLUTEN-11766][VL] Implement the executeCollect() method in ColumnarCollectLimitExec#11802
Open
JkSelf wants to merge 3 commits intoapache:mainfrom
Open
[GLUTEN-11766][VL] Implement the executeCollect() method in ColumnarCollectLimitExec#11802JkSelf wants to merge 3 commits intoapache:mainfrom
JkSelf wants to merge 3 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
zhouyuan
reviewed
Mar 20, 2026
Member
zhouyuan
left a comment
zhouyuan
left a comment
There was a problem hiding this comment.
code looks good, could you please also add a test on this?
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
jackylee-ch
reviewed
Mar 23, 2026
| override def executeCollect(): Array[InternalRow] = { | ||
| child match { | ||
| case l: ColumnarCollectLimitBaseExec => | ||
| l.executeCollect() |
Contributor
There was a problem hiding this comment.
Do we need to support this for ch backend?
Contributor
Author
There was a problem hiding this comment.
@jackylee-ch No. Move this changes into VeloxColumnarToRowExec.
Contributor
Author
@zhouyuan https://github.com/apache/gluten/blob/main/gluten-ut/spark35/src/test/scala/org/apache/spark/sql/execution/GlutenSQLCollectLimitExecSuite.scala can cover this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fix #11766
How was this patch tested?
Manual test.
Before this PR:
After this PR
Was this patch authored or co-authored using generative AI tooling?
No