[VL] Remove dead config spark.gluten.velox.fs.s3a.connect.timeout#11810
Open
xumingming wants to merge 1 commit intoapache:mainfrom
Open
[VL] Remove dead config spark.gluten.velox.fs.s3a.connect.timeout#11810xumingming wants to merge 1 commit intoapache:mainfrom
xumingming wants to merge 1 commit intoapache:mainfrom
Conversation
The config `spark.gluten.velox.fs.s3a.connect.timeout` was originally introduced in GLUTEN-5659 and explicitly read by ConfigExtractor.cc to set the S3 TCP connect timeout (connectTimeoutMs). In GLUTEN-9182, ConfigExtractor.cc was refactored to use a suffix-map approach reading `spark.hadoop.fs.s3a.connection.establish.timeout` for connectTimeoutMs and `spark.hadoop.fs.s3a.connection.timeout` for requestTimeoutMs. The old key was never cleaned up, leaving `AWS_S3_CONNECT_TIMEOUT` defined in VeloxConfig.scala but never referenced, and the key forwarded into the native conf map but never consumed by any C++ code. Remove the config definition, its entries in nativeKeys and getNativeBackendConf defaults, and the documentation row.
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The config
spark.gluten.velox.fs.s3a.connect.timeoutwas originally introduced in GLUTEN-5659 and explicitly read by ConfigExtractor.cc to set the S3 TCP connect timeout (connectTimeoutMs).In GLUTEN-9182, ConfigExtractor.cc was refactored to use a suffix-map approach reading
spark.hadoop.fs.s3a.connection.establish.timeoutfor connectTimeoutMs andspark.hadoop.fs.s3a.connection.timeoutfor requestTimeoutMs. The old key was never cleaned up, leavingAWS_S3_CONNECT_TIMEOUTdefined in VeloxConfig.scala but never referenced, and the key forwarded into the native conf map but never consumed by any C++ code.Remove the config definition, its entries in nativeKeys and getNativeBackendConf defaults, and the documentation row.
Close #11809
How was this patch tested?
Manual test.
Was this patch authored or co-authored using generative AI tooling?
No.