[GLUTEN-11550][UT] Fix 2 TPCDS traits, enable 8 disabled test suites for Spark 4.x#11816
Merged
zhouyuan merged 7 commits intoapache:mainfrom Apr 10, 2026
Merged
[GLUTEN-11550][UT] Fix 2 TPCDS traits, enable 8 disabled test suites for Spark 4.x#11816zhouyuan merged 7 commits intoapache:mainfrom
zhouyuan merged 7 commits intoapache:mainfrom
Conversation
baibaichen
changed the title
|
Run Gluten Clickhouse CI on x86 |
baibaichen
force-pushed
the
fix/11550-enable-all
branch
from
5782b90 to
451760d
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
baibaichen
force-pushed
the
fix/11550-enable-all
branch
from
431721f to
bb137ad
Compare
baibaichen
changed the title
|
Run Gluten Clickhouse CI on x86 |
This was referenced Apr 10, 2026
baibaichen
force-pushed
the
fix/11550-enable-all
branch
from
bb137ad to
c0c68ff
Compare
|
Run Gluten Clickhouse CI on x86 |
baibaichen
force-pushed
the
fix/11550-enable-all
branch
2 times, most recently
from
8ec0857 to
0c2ca3d
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
baibaichen
force-pushed
the
fix/11550-enable-all
branch
from
0c2ca3d to
d9b6122
Compare
|
Run Gluten Clickhouse CI on x86 |
baibaichen
force-pushed
the
fix/11550-enable-all
branch
from
d9b6122 to
666ce08
Compare
|
Run Gluten Clickhouse CI on x86 |
baibaichen
changed the title
baibaichen
force-pushed
the
fix/11550-enable-all
branch
from
666ce08 to
9b8fd96
Compare
baibaichen
changed the title
|
Run Gluten Clickhouse CI on x86 |
baibaichen
force-pushed
the
fix/11550-enable-all
branch
from
9b8fd96 to
169b334
Compare
|
Run Gluten Clickhouse CI on x86 |
…nges) Fix trait GlutenTestsCommonTrait -> GlutenSQLTestsTrait: - GlutenTPCDSQueryWithStatsSuite - GlutenTPCDSQueryANSISuite Disable GlutenStreamingQueryHashPartitionVerifySuite (wrong trait, runs as vanilla Spark) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Wrap exception in glutenCheckExpression with fail() to match Spark's checkEvaluationWithoutCodegen behavior. No testGluten override needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…extFileV2Suite Override testFile() to use getWorkspaceFilePath() instead of default jar-based path. The default testFile() returns jar:file: URI which Hadoop Path does not support. Same pattern used by GlutenCSVSuite, GlutenJsonSuite, GlutenParquetIOSuite. V1 3/3 passed, V2 3/3 passed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Override test to find ColumnarToRowExecBase instead of ColumnarToRowExec. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
6 tests rewritten with testGluten (match TakeOrderedAndProjectExecTransformer, LimitExecTransformer, ColumnarCollectLimitBaseExec). Original tests excluded. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
testGluten for shuffle-replicate-nl matching CartesianProductExecTransformer. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… testGluten Enable and fix: - GlutenDataSourceScanExecRedactionSuite: testGluten matching FileSourceScanExecTransformer - GlutenDataSourceV2ScanExecRedactionSuite: testGluten matching BatchScanExecTransformer - VTS: enable JoinHint with exclude, enable DataSource suites with excludes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
baibaichen
force-pushed
the
fix/11550-enable-all
branch
from
169b334 to
1c96a55
Compare
baibaichen
changed the title
|
Run Gluten Clickhouse CI on x86 |
zhouyuan
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix 2 TPCDS suite traits, disable 1 wrong-trait suite, and enable 8 previously disabled Spark 4.x test suites by adding Gluten-aware
testGlutenoverrides and fixing test configurations.Trait fixes + disable (commit 1):
Suites enabled (8):
testFile()override withgetWorkspaceFilePathtestFile()override withgetWorkspaceFilePathColumnarToRowExecBase)SortExecTransformer,TakeOrderedAndProjectExecTransformer)CartesianProductExecTransformer)FileSourceScanExecTransformer)BatchScanExecTransformer)Root cause categories:
testGlutenoverrides match the correct class namesgetWorkspaceFilePathoverrideEvery
.exclude()has a matchingtestGlutenoverride (11 total).How was this patch tested?
All suites verified locally with
SPARK_ANSI_SQL_MODE=falseusing:Related issue: #11550