[GLUTEN-11920][CORE] Keep columnar children for dual-mode parents with row output#12004
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
For dual-mode parents that support both columnar and row-based execution, Gluten previously let the child convention follow the parent's output convention by default. When the parent was required to produce rows, this could incorrectly push a row requirement down to its children even though the parent could still consume batch input and satisfy the row output requirement by itself.
This PR changes dual-mode parents to keep a batch child convention under a row output requirement, which aligns transition insertion with Spark behavior and avoids unnecessary row transitions.
The change is applied in both the plan-side child convention derivation and the transition convention derivation so the behavior stays consistent.
This PR also:
GlutenColumnarRulesSuiteon Spark 4.1.How was this patch tested?
GlutenColumnarRulesSuiteon Spark 4.1 to cover the fixed behavior.issue: #11920
fix in spark: apache/spark#50239
Was this patch authored or co-authored using generative AI tooling?