Skip to content

[GLUTEN-11867] Add JDK 25 build support#12012

Merged
zhouyuan merged 5 commits into
apache:mainfrom
Yao-MR:enhancement/enable_jdk25
May 14, 2026
Merged

[GLUTEN-11867] Add JDK 25 build support#12012
zhouyuan merged 5 commits into
apache:mainfrom
Yao-MR:enhancement/enable_jdk25

Conversation

@Yao-MR
Copy link
Copy Markdown
Contributor

@Yao-MR Yao-MR commented Apr 29, 2026

What changes are proposed in this pull request?

Add JDK 25 build support for Gluten with Spark 4.0+ (Velox backend).

Key changes:

  1. pom.xml: Added java-25 Maven profile with the following configurations:
    • Set scala.release.version to 21 since Scala 2.13 does not support -release:25
    • Set maven.compiler.source/target to 21 to avoid Scala emit errors with target 25
    • Upgraded spotless.version to 2.44.4 and googlejavaformat.version to 1.25.2
    • Disabled spotless check (spotless.check.skip=true) as spotless-maven-plugin 2.44.x is incompatible with JDK 25 due to internal API removal (com.sun.tools.javac.util.Log$DeferredDiagnosticHandler.getDiagnostics())
    • Added java-25 to the requireActiveProfile rules for Spark 4.0 and 4.1 enforcer checks
  2. tools/gluten-it/pom.xml: Added java-25 profile with compatible spotless and google-java-format versions
  3. .github/workflows/velox_backend_x86.yml: Added java-25 to the CI build matrix, excluded it from Spark 3.x builds and Ubuntu 20.04 (which lacks openjdk-25 packages)
  4. docs/developers/NewToGluten.md: Updated documentation to mention JDK 21 and 25 support for Spark 4.0+

ISSUE : #11867

How was this patch tested?

Build completed successfully.

Was this patch authored or co-authored using generative AI tooling?

@github-actions github-actions Bot added CORE works for Gluten Core INFRA TOOLS DOCS labels Apr 29, 2026
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@Yao-MR Yao-MR closed this Apr 29, 2026
@Yao-MR Yao-MR reopened this Apr 29, 2026
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@zhouyuan zhouyuan changed the title 【Gluten-11867] Add JDK 25 build support [GLUTEN-11867] Add JDK 25 build support Apr 29, 2026
@Yao-MR Yao-MR force-pushed the enhancement/enable_jdk25 branch from 055d4f4 to aea7606 Compare April 30, 2026 03:19
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@Yao-MR Yao-MR closed this Apr 30, 2026
@zhouyuan
Copy link
Copy Markdown
Member

zhouyuan commented May 8, 2026

Hi @Yao-MR, the patch looks in good shape already, are you planning to do more improvement on it?

@Yao-MR Yao-MR reopened this May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Run Gluten Clickhouse CI on x86

@Yao-MR
Copy link
Copy Markdown
Contributor Author

Yao-MR commented May 8, 2026

Hi @Yao-MR, the patch looks in good shape already, are you planning to do more improvement on it?

hi @zhouyuan
yes, and there is some failed tests, and will reopen once pass test, and for now open for Draft

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

Run Gluten Clickhouse CI on x86

@Yao-MR Yao-MR force-pushed the enhancement/enable_jdk25 branch from f623915 to 6511522 Compare May 11, 2026 02:21
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@Yao-MR Yao-MR force-pushed the enhancement/enable_jdk25 branch from 6511522 to 3257be4 Compare May 11, 2026 02:51
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@Yao-MR Yao-MR force-pushed the enhancement/enable_jdk25 branch from 3257be4 to e57d1fb Compare May 11, 2026 03:51
@Yao-MR Yao-MR marked this pull request as ready for review May 11, 2026 03:51
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Copy link
Copy Markdown
Member

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@Yao-MR
Copy link
Copy Markdown
Contributor Author

Yao-MR commented May 12, 2026

hi @zhouyuan do you have any idea how to inspect the Gluten ClickHouse CI fail ? it seems that this CI pipeline can not
give detail error info

@jackylee-ch
Copy link
Copy Markdown
Contributor

hi @zhouyuan do you have any idea how to inspect the Gluten ClickHouse CI fail ? it seems that this CI pipeline can not give detail error info

You can find View as Plain text in Gluten Clickhouse CI, then look for BUILD FAILURE or simply *** failed ***, that's the test failures.

the current CI failed with - SPARK-33084: Add jar support Ivy URI in SQL *** FAILED ***, it seems doesn't related to current pr. @zzcclp can we ignore it until this is fixed?

@Yao-MR
Copy link
Copy Markdown
Contributor Author

Yao-MR commented May 12, 2026

hi @zhouyuan do you have any idea how to inspect the Gluten ClickHouse CI fail ? it seems that this CI pipeline can not give detail error info

You can find View as Plain text in Gluten Clickhouse CI, then look for BUILD FAILURE or simply *** failed ***, that's the test failures.

the current CI failed with - SPARK-33084: Add jar support Ivy URI in SQL *** FAILED ***, it seems doesn't related to current pr. @zzcclp can we ignore it until this is fixed?

this is the gluten clickhouse ci url: https://opencicd.kyligence.com/login?from=%2Fjob%2Fgluten%2Fjob%2Fgluten-ci%2F19699%2F

login need name and password, it is a private Jenkins url,

@jackylee-ch
Copy link
Copy Markdown
Contributor

this is the gluten clickhouse ci url: https://opencicd.kyligence.com/login?from=%2Fjob%2Fgluten%2Fjob%2Fgluten-ci%2F19699%2F

login need name and password, it is a private Jenkins url,

the user and password can be found in the New CI System , which is in ClickHouse.md.

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@Yao-MR
Copy link
Copy Markdown
Contributor Author

Yao-MR commented May 12, 2026

this is the gluten clickhouse ci url: https://opencicd.kyligence.com/login?from=%2Fjob%2Fgluten%2Fjob%2Fgluten-ci%2F19699%2F
login need name and password, it is a private Jenkins url,

the user and password can be found in the New CI System , which is in ClickHouse.md.

thanks for the info

@Yao-MR
Copy link
Copy Markdown
Contributor Author

Yao-MR commented May 14, 2026

hi, @philo-he we also drive the jdk upgrade, can you also help review it ?

Copy link
Copy Markdown
Member

@philo-he philo-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @jackylee-ch in case you have any comment.

BTW, the CI jobs are a bit redundant. For TPC tests, we could consider keeping only Ubuntu 22.04 and dropping Ubuntu 20.04 in the future.

@zhouyuan zhouyuan merged commit 1cc3535 into apache:main May 14, 2026
62 checks passed
@zhouyuan
Copy link
Copy Markdown
Member

@Yao-MR thanks for contributing on this!

@zhouyuan zhouyuan mentioned this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core DOCS INFRA TOOLS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants