[GLUTEN-11867] Add JDK 25 build support#12012
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
055d4f4 to
aea7606
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Hi @Yao-MR, the patch looks in good shape already, are you planning to do more improvement on it? |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
f623915 to
6511522
Compare
|
Run Gluten Clickhouse CI on x86 |
6511522 to
3257be4
Compare
|
Run Gluten Clickhouse CI on x86 |
3257be4 to
e57d1fb
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
hi @zhouyuan do you have any idea how to inspect the Gluten ClickHouse CI fail ? it seems that this CI pipeline can not |
You can find the current CI failed with |
this is the gluten clickhouse ci url: https://opencicd.kyligence.com/login?from=%2Fjob%2Fgluten%2Fjob%2Fgluten-ci%2F19699%2F login need name and password, it is a private Jenkins url, |
the user and password can be found in the |
|
Run Gluten Clickhouse CI on x86 |
thanks for the info |
|
hi, @philo-he we also drive the jdk upgrade, can you also help review it ? |
philo-he
left a comment
There was a problem hiding this comment.
LGTM. cc @jackylee-ch in case you have any comment.
BTW, the CI jobs are a bit redundant. For TPC tests, we could consider keeping only Ubuntu 22.04 and dropping Ubuntu 20.04 in the future.
|
@Yao-MR thanks for contributing on this! |
What changes are proposed in this pull request?
Add JDK 25 build support for Gluten with Spark 4.0+ (Velox backend).
Key changes:
java-25Maven profile with the following configurations:scala.release.versionto21since Scala 2.13 does not support-release:25maven.compiler.source/targetto21to avoid Scala emit errors with target25spotless.versionto2.44.4andgooglejavaformat.versionto1.25.2spotless.check.skip=true) as spotless-maven-plugin 2.44.x is incompatible with JDK 25 due to internal API removal (com.sun.tools.javac.util.Log$DeferredDiagnosticHandler.getDiagnostics())java-25to therequireActiveProfilerules for Spark 4.0 and 4.1 enforcer checksjava-25profile with compatible spotless and google-java-format versionsjava-25to the CI build matrix, excluded it from Spark 3.x builds and Ubuntu 20.04 (which lacks openjdk-25 packages)ISSUE : #11867
How was this patch tested?
Build completed successfully.
Was this patch authored or co-authored using generative AI tooling?