Skip to content

[MINOR][VL] Improve validation log messages for aggregate function signature binding #12031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philo-he merged 2 commits into from
May 5, 2026
Merged

[MINOR][VL] Improve validation log messages for aggregate function signature binding #12031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96188a1
Initial
philo-he May 3, 2026
dc7bfd4
Fix compile error
philo-he May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,7 @@ bool SubstraitToVeloxPlanValidator::validateAggRelFunctionType(const ::substrait
auto funcName = planConverter_->toAggregationFunctionName(baseFuncName, funcStep, resultType);
auto signaturesOpt = exec::getAggregateFunctionSignatures(funcName);
if (!signaturesOpt) {
LOG_VALIDATION_MSG("can not find function signature for " + funcName + " in AggregateRel.");
LOG_VALIDATION_MSG("No function signatures found for function name: " + funcName);
return false;
}

Expand All @@ -1179,16 +1179,32 @@ bool SubstraitToVeloxPlanValidator::validateAggRelFunctionType(const ::substrait
}

if (resolveType == nullptr) {
LOG_VALIDATION_MSG("Validation failed for function " + funcName + " resolve type in AggregateRel.");
return false;
LOG_VALIDATION_MSG("Failed to resolve intermediate/return type for function " + funcName);
break;
}

resolved = true;
break;
}
}
if (!resolved) {
LOG_VALIDATION_MSG("Validation failed for function " + funcName + " bind signatures in AggregateRel.");
std::vector<std::string> inputTypeStrs;
for (const auto& type : types) {
inputTypeStrs.push_back(type->toString());
}

std::vector<std::string> signatureStrs;
for (const auto& signature : signaturesOpt.value()) {
signatureStrs.push_back(signature->toString());
}

LOG_VALIDATION_MSG(fmt::format(
"Validation failed for function {} when binding signatures.\n"
" Input types: [{}]\n"
" Registered signatures:\n {}",
funcName,
folly::join(", ", inputTypeStrs),
folly::join("\n ", signatureStrs)));
return false;
}
}
Expand Down
Loading