Skip to content

[GLUTEN-12044][CH] Fix build on arm#12046

Merged
zzcclp merged 1 commit into
apache:mainfrom
zhanglistar:fix/build-on-arm
May 6, 2026
Merged

[GLUTEN-12044][CH] Fix build on arm#12046
zzcclp merged 1 commit into
apache:mainfrom
zhanglistar:fix/build-on-arm

Conversation

@zhanglistar
Copy link
Copy Markdown
Contributor

@zhanglistar zhanglistar commented May 6, 2026

What changes are proposed in this pull request?

Fix issue #12044.
Fix an ARM64/NEON build failure in LocalDigitsToAsciiDigitForDate. The previous implementation called simd8_u8::load(...).is_ascii(), but on ARM64 the simdjson simd8<uint8_t>::load returns the underlying vector type, so the member call is invalid.

This PR replaces the ASCII check with a portable SIMD predicate using any_bits_set_anywhere(simd8_u8(0x80)) to detect any byte with the high bit set, preserving the original intent while compiling across SIMD backends.

How was this patch tested?

  • Rebuilt the failing object/target in the ARM64 cross-compilation environment and confirmed it compiles successfully.
  • (Optional) Ran a full build to ensure no regressions.

Was this patch authored or co-authored using generative AI tooling?

Generated-by: Cursor (GPT-5.2)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Run Gluten Clickhouse CI on x86

Copy link
Copy Markdown
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, build with the arm platform passed.

@zzcclp
Copy link
Copy Markdown
Contributor

zzcclp commented May 6, 2026

image

@zzcclp zzcclp merged commit 74c9638 into apache:main May 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants