[VL] Fix gflags mode in folly on Centos9#12265
Merged
Merged
Conversation
zhouyuan
changed the title
on dynamic lib testing env, the gflags_shared need to enabled in folly Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
wip_fix_centos9_folly_build
branch
from
248258c to
55321d9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes CentOS 9–specific workaround logic that was patching Velox/Folly’s gflags linkage behavior in CI and in the Velox fetch/setup helper, and instead relies on upstream Velox’s VELOX_BUILD_SHARED mechanism when building the “dynamic-build” Docker images. This aligns Gluten’s build with the intended upstream configuration path and drops now-stale post-install sed patches in workflows.
Changes:
- Remove the CentOS9
sedpatch inget-velox.shthat forced-DGFLAGS_SHARED=TRUEin Velox’sscripts/setup-common.sh. - Set
VELOX_BUILD_SHARED=ONduring CentOS8/9 dynamic Docker image builds to drive upstream Velox dependency builds in shared mode. - Remove CI workflow
sedhacks that rewrote Folly CMake targets fromgflags_statictogflags_shared.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ep/build-velox/src/get-velox.sh | Drops the CentOS9-specific patching of Velox’s setup script. |
| dev/docker/Dockerfile.centos9-dynamic-build | Exports VELOX_BUILD_SHARED=ON for shared-deps builds in the CentOS9 dynamic image. |
| dev/docker/Dockerfile.centos8-dynamic-build | Exports VELOX_BUILD_SHARED=ON for shared-deps builds in the CentOS8 dynamic image. |
| .github/workflows/velox_backend_x86.yml | Removes the Folly targets sed workaround from the x86 CI job. |
| .github/workflows/velox_backend_arm.yml | Removes the Folly targets sed workaround from the ARM CI job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zhouyuan
commented
Jun 8, 2026
| fi; \ | ||
| cd /opt/gluten; \ | ||
| source /opt/rh/gcc-toolset-12/enable; \ | ||
| export VELOX_BUILD_SHARED=ON; \ |
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Remove the workaround for folly gflags mode on centos9 image introduced in #12223
How was this patch tested?
pass GHA
Was this patch authored or co-authored using generative AI tooling?