Skip to content

Enable minute/second(timestamp_ntz) native execution in Velox backend.#12295

Open
Mariamalmesfer wants to merge 1 commit into
apache:mainfrom
Mariamalmesfer:ts-ntz-minute-second-support
Open

Enable minute/second(timestamp_ntz) native execution in Velox backend.#12295
Mariamalmesfer wants to merge 1 commit into
apache:mainfrom
Mariamalmesfer:ts-ntz-minute-second-support

Conversation

@Mariamalmesfer

@Mariamalmesfer Mariamalmesfer commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Enable minute(timestamp_ntz) and second(timestamp_ntz) to run natively in the Velox backend instead of falling back to Spark.
Velox PR: facebookincubator/velox#17759

@github-actions github-actions Bot added CORE works for Gluten Core VELOX labels Jun 14, 2026
@github-actions

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@Mariamalmesfer

Copy link
Copy Markdown
Contributor Author

CI failure is expected — depends on facebookincubator/velox#17759 which is not yet in the Velox daily build used by CI.

@Mariamalmesfer Mariamalmesfer force-pushed the ts-ntz-minute-second-support branch from fafe18c to 44da563 Compare June 17, 2026 08:47
@github-actions

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@Mariamalmesfer Mariamalmesfer force-pushed the ts-ntz-minute-second-support branch from 44da563 to 456640e Compare June 18, 2026 13:46
@github-actions

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@Mariamalmesfer Mariamalmesfer force-pushed the ts-ntz-minute-second-support branch from 456640e to 0f35396 Compare June 22, 2026 08:54
@github-actions

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@Mariamalmesfer Mariamalmesfer force-pushed the ts-ntz-minute-second-support branch from 0f35396 to 467e7dc Compare June 24, 2026 09:33
@github-actions

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Gluten’s Spark-plan validation logic so minute(timestamp_ntz) and second(timestamp_ntz) projections can be treated as natively supported by the Velox backend (avoiding Spark fallback), and adds Velox backend validation coverage for the new behavior.

Changes:

  • Extend the TimestampNTZ validation exception in Validators to recognize Minute and Second expressions (in addition to Hour) operating on timestamp_ntz.
  • Add Velox backend suite assertions that minute(ts) and second(ts) over timestamp_ntz produce a native ProjectExecTransformer plan.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala Expands the NTZ “extract” allowance in ProjectExec from hour-only to hour/minute/second.
backends-velox/src/test/scala/org/apache/gluten/functions/DateFunctionsValidateSuite.scala Adds validation tests ensuring minute(timestamp_ntz) and second(timestamp_ntz) are planned natively (no fallback).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Mariamalmesfer Mariamalmesfer force-pushed the ts-ntz-minute-second-support branch from 467e7dc to 488a06e Compare June 30, 2026 10:30
@github-actions

Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core VELOX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants