[GLUTEN-12303][VL] Support async multipart upload for S3 writes#12305
Open
ReemaAlzaid wants to merge 13 commits into
Open
[GLUTEN-12303][VL] Support async multipart upload for S3 writes#12305ReemaAlzaid wants to merge 13 commits into
ReemaAlzaid wants to merge 13 commits into
Conversation
Contributor
|
FYI, @weixiuli. Since the PR isn't imported into Velox. We extend Velox's S3 file system and move your enhancement into Gluten. |
Member
|
@ReemaAlzaid the configuration issue should be re-generated by https://github.com/apache/gluten/blob/main/dev/gen-all-config-docs.sh |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an optional Velox-backend S3 write path that uploads multipart parts asynchronously using a shared upload thread pool, along with new Spark/Gluten configs and documentation to control concurrency.
Changes:
- Introduces
spark.gluten.velox.s3UploadPartAsync,spark.gluten.velox.s3MaxConcurrentUploadNum, andspark.gluten.velox.s3UploadThreads(plus docs) to enable/tune async multipart uploads. - Extends native config extraction to populate corresponding
hive.s3.*keys and adds a focused C++ unit test. - Adds a new
s3_async_upload_benchmarkto compare sync vs async upload performance.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/velox-configuration.md | Documents new S3 async upload knobs (and reorders/updates a couple of config rows). |
| docs/get-started/VeloxS3.md | Adds a section describing how to enable and tune async multipart uploads. |
| cpp/velox/utils/ConfigExtractor.cc | Maps the new Spark/Gluten configs into Velox hive.s3.* configuration. |
| cpp/velox/tests/GlutenS3FileSystemTest.cc | Adds a unit test validating extraction of the new async upload configs. |
| cpp/velox/filesystem/GlutenS3FileSystem.h | Extends the S3 FS wrapper with async-upload-related state. |
| cpp/velox/filesystem/GlutenS3FileSystem.cc | Implements async multipart upload write path and config handling. |
| cpp/velox/benchmarks/S3AsyncUploadBenchmark.cc | New benchmark for sync vs async upload throughput/latency comparisons. |
| cpp/velox/benchmarks/CMakeLists.txt | Registers the new benchmark behind ENABLE_S3. |
| backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala | Adds the three new Spark configs to the Velox config registry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+355
to
+359
| static std::shared_ptr<folly::CPUThreadPoolExecutor> uploadThreadPool(uint32_t uploadThreads) { | ||
| std::lock_guard<std::mutex> l(uploadThreadPoolMutex_); | ||
| if (!sharedUploadThreadPool_) { | ||
| sharedUploadThreadPool_ = std::make_shared<folly::CPUThreadPoolExecutor>( | ||
| uploadThreads, std::make_shared<folly::NamedThreadFactory>("s3-upload-thread")); |
Comment on lines
+336
to
+340
| RECORD_METRIC_VALUE(filesystems::kMetricS3StartedUploads); | ||
| uploadPart({currentPart_->data(), currentPart_->size()}, true); | ||
| waitForAsyncUploads(); | ||
| VELOX_CHECK_EQ(uploadState_.partNumber, uploadState_.completedParts.size()); | ||
| completeMultipartUpload(); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is ported from facebookincubator/velox#14472. The original author is @weixiuli
What changes were proposed in this pull request?
This PR adds Gluten-side support for multi-threaded asynchronous multipart upload for S3 compatible object storage in the Velox backend.
When enabled, Gluten uses an async S3 write path that uploads multipart upload parts through a shared upload thread pool. The number of in-flight part uploads per file and the upload thread pool size are configurable.
The existing synchronous S3 write path remains the default behavior.
This PR also adds a benchmark for comparing synchronous and asynchronous S3 multipart upload performance.
#12303
How was this patch tested?
Built the Velox backend with S3 enabled and ran the S3 async upload benchmark against MinIO.
Example benchmark command: