[VL] Fix dynamic link on rhel#12359
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Velox backend CMake linking to address undefined-symbol failures on RHEL by changing where Folly is discovered/linked relative to Velox/Thrift components.
Changes:
- Moves
find_package(Folly REQUIRED CONFIG)andtarget_link_libraries(... Folly::folly)to a later point incpp/velox/CMakeLists.txt. - Removes the earlier Folly link line so Folly is linked closer to
external::veloxthrift/ thrift-related linkage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # `-DCMAKE_PREFIX_PATH="${folly lib path}" to cmake arguments. It is also | ||
| # applicable to other dependencies. | ||
| find_package(Folly REQUIRED CONFIG) | ||
| target_link_libraries(velox PUBLIC Folly::folly) |
Comment on lines
+385
to
+387
| # If folly is not installed in system lib paths, please add | ||
| # `-DCMAKE_PREFIX_PATH="${folly lib path}" to cmake arguments. It is also | ||
| # applicable to other dependencies. |
zhouyuan
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the undefined symbol error