[VL] Result mismatch with vanilla Spark SQL on atan2#1689
Merged
Conversation
|
Run Gluten Clickhouse CI |
zhztheplayer
changed the title
zhztheplayer
changed the title
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
rui-mo
approved these changes
May 26, 2023
brijrajk
added a commit
to brijrajk/incubator-gluten
that referenced
this pull request
Jun 2, 2026
…teSuite The atan2 test was marked ignore after a result mismatch (PR apache#1689, 2023) caused by Velox using std::atan2 directly. That was fixed upstream in oap-project/velox#263 which added sparksql::Atan2Function that mirrors Spark's Math.atan2(y + 0.0, x + 0.0) behaviour to normalise -0 inputs. The ignore was never removed after the fix landed. Also promotes MathFunctionsValidateSuite from abstract class to class (fixing the RAS-removal oversight from PR apache#11756, the same fix already applied to DateFunctionsValidateSuite) and disables ANSI mode for Spark 4, consistent with the approach in PR apache#12158 which adds further tests to this same suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependency oap-project/velox#263