Merged
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
506bffc to
74a0c12
Compare
959e087 to
3f87780
Compare
zzcclp
reviewed
Oct 17, 2022
jvm/src/main/scala/io/glutenproject/extension/ColumnarOverrides.scala
Outdated
Show resolved
Hide resolved
Contributor
|
Please rebase to main and add some UTs |
29af11c to
b57d73e
Compare
zzcclp
reviewed
Oct 20, 2022
jvm/src/main/scala/io/glutenproject/backendsapi/ITransformerApi.scala
Outdated
Show resolved
Hide resolved
zzcclp
reviewed
Oct 20, 2022
jvm/src/main/scala/io/glutenproject/extension/ColumnarOverrides.scala
Outdated
Show resolved
Hide resolved
Contributor
|
Please rebase to main |
relate to issue Kyligence/ClickHouse#45
b57d73e to
bbd8761
Compare
Contributor
Author
|
wait for Kyligence/ClickHouse#175 be merged |
25a6d6e to
98f0d8b
Compare
rui-mo
reviewed
Oct 31, 2022
jvm/src/main/scala/io/glutenproject/execution/BasicPhysicalOperatorTransformer.scala
Show resolved
Hide resolved
rui-mo
approved these changes
Nov 1, 2022
Contributor
rui-mo
left a comment
There was a problem hiding this comment.
Verified on Jenkins. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relate to the issue Kyligence/ClickHouse#45
What changes were proposed in this pull request?
A empty base_schema will be made in the
scannode when run the following queriesThe backend source node will return empty data or throw an exception when there is no column to read.
So we fill a attribute to read in
FileSourceScanExec.Another problem is in
ProjectExecTransformer. IfProjectExecTransformer's child is anColumnarInputAdapterandprojectListis empty, it would generate a scan node with empty base_schema. So whenchildCtxis null, we don't return directly.How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)