[GLUTEN-6656][CELEBORN] Fix CelebornColumnarShuffleWriter assertion failed#6657
Merged
taiyang-li merged 1 commit intoapache:mainfrom Aug 1, 2024
Merged
[GLUTEN-6656][CELEBORN] Fix CelebornColumnarShuffleWriter assertion failed#6657taiyang-li merged 1 commit intoapache:mainfrom
taiyang-li merged 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI |
Member
SteNicholas
reviewed
Jul 31, 2024
| } | ||
|
|
||
| assert(nativeShuffleWriter != -1L) | ||
| // If all of the ColumnarBatch have empty rows, the nativeShuffleWriter still equals -1 |
Member
There was a problem hiding this comment.
When !records.hasNext=true, does this also need to invoke handleEmptyIterator?
Contributor
Author
There was a problem hiding this comment.
Yes，the logic of invoking handleEmptyIterator when !records.hasNext=true is in the write method of super class CelebornColumnarShuffleWriter.
Contributor
Author
SteNicholas
approved these changes
Aug 1, 2024
weiting-chen
pushed a commit
to weiting-chen/gluten
that referenced
this pull request
Nov 12, 2024
weiting-chen
added a commit
that referenced
this pull request
Nov 18, 2024
* [CELEBORN] CHCelebornColumnarShuffleWriter supports celeborn.client.spark.shuffle.writer to use memory sort shuffle in ClickHouse backend (#6432) * [GLUTEN-6656][CELEBORN] Fix CelebornColumnarShuffleWriter assertion failed (#6657) --------- Co-authored-by: Nicholas Jiang <programgeek@163.com> Co-authored-by: exmy <xumovens@gmail.com>
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After #6432, if all of the ColumnarBatch have empty rows in
CHCelebornColumnarShuffleWriter, thenativeShuffleWriterwon't be initialized and causesassertion failed. TheVeloxCelebornColumnarShuffleWriteralso has the same issue even without #6432.(Fixes: #6656)
How was this patch tested?
PASS CI