[GLUTEN-8327][CORE][Part-3] Introduce the ConfigEntry to gluten config#8431
[GLUTEN-8327][CORE][Part-3] Introduce the ConfigEntry to gluten config#8431baibaichen merged 2 commits intoapache:mainfrom
ConfigEntry to gluten config#8431Conversation
ConfigEntry to gluten config
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
|
@yikf Thanks for bringing the code back. Is there any performance-related change you wanted to highlight between this one and the original PR? |
yes, after splitting the original PR, we identified the issue as being related to the current PR's changes. after offline discussion and investigation with @baibaichen , it was determined that the problem was caused by the modification. Now, we have avoided synchronization and copying. Last night, @baibaichen verified this PR and there are no performance issues now. |
|
@zhztheplayer BTW, Please don't merge this PR for the time being. Regarding the introduction of the custom ConfigEntry, @baibaichen have another idea. We can discuss it. |
|
With this commit 8bf2666, the performance issue is fixed, see below image: |
|
Run Gluten Clickhouse CI on x86 |
|
===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====
|

What changes were proposed in this pull request?
This PR is the part-3 of the revert commit back and is used to introduce the
ConfigEntryto gluten config.How was this patch tested?
GA.