[GLUTEN-8462][CORE] Raise a meaningful error when no component is found from classpath#8468
Merged
zhztheplayer merged 4 commits intoapache:mainfrom Jan 9, 2025
Merged
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
PHILO-HE
reviewed
Jan 9, 2025
| components.nonEmpty, | ||
| s"No component files found in container directories named with " + | ||
| s"'META-INF/gluten-components' from classpath. JVM classpath value " + | ||
| s"is: ${System.getProperty("java.class.path")}" |
Member
There was a problem hiding this comment.
@zhztheplayer, is user configured extraClassPath covered by java.class.path?
Member
Author
There was a problem hiding this comment.
Yes, usually it is included. I am investigating on issue #8462 so perhaps we shouldn't rely on java.class.path in future. But at his moment this error message is needed.
PHILO-HE
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no component files (with name
META-INF/gluten-components/<classname>) found from classpath, raise an error instead of running into UB.