[GLUTEN-8483][CORE] A stable and universal way to find component files#8486
Merged
zhztheplayer merged 4 commits intoapache:mainfrom Jan 10, 2025
Merged
[GLUTEN-8483][CORE] A stable and universal way to find component files#8486zhztheplayer merged 4 commits intoapache:mainfrom
zhztheplayer merged 4 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
Member
Author
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
changed the title
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
changed the title
Contributor
@zhztheplayer hii, it works in my case. |
Member
Author
Sure, will merge. Thank you for helping verify the change! |
PHILO-HE
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8483
Use
ClassLoader.getResourcesfor the discovery of the component files instead of reading system propertyjava.class.path. The new way will be suitable for more scenarios including cases that class loader is customized or Gluten Jar file is not loaded with regular-cpJVM argument.