Skip to content

[Gluten-9334][CH] Support delta metadata column file_path and row_index for mergetree#9340

Merged
zzcclp merged 3 commits intoapache:mainfrom
loneylee:9334
Apr 16, 2025
Merged

[Gluten-9334][CH] Support delta metadata column file_path and row_index for mergetree#9340
zzcclp merged 3 commits intoapache:mainfrom
loneylee:9334

Conversation

@loneylee
Copy link
Member

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #9334)

How was this patch tested?

test by ut

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions
Copy link

Run Gluten ClickHouse CI on ARM

@loneylee loneylee requested a review from Copilot April 16, 2025 11:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • backends-clickhouse/src-delta-32/test/scala/org/apache/spark/gluten/delta/GlutenDeltaMergetreeDeletionVectorSuite.scala: Language not supported
  • backends-clickhouse/src/test/scala/org/apache/gluten/execution/GlutenClickHouseTPCHAbstractSuite.scala: Language not supported
Comments suppressed due to low confidence (1)

cpp-ch/local-engine/Parser/RelParsers/MergeTreeRelParser.cpp:144

  • [nitpick] The variable name 'a' is ambiguous; consider renaming it to a more descriptive name such as 'dataType' to improve clarity.
auto a= std::get<1>(tuple);

@github-actions
Copy link

Run Gluten ClickHouse CI on ARM

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzcclp zzcclp merged commit b10ee0d into apache:main Apr 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CH] Support column _tmp_metadata_row_index read from mergetree

3 participants