[CORE] Make max broadcast table size configurable#9359
Merged
zhouyuan merged 2 commits intoapache:mainfrom Apr 18, 2025
Merged
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI on x86 |
Yohahaha
reviewed
Apr 18, 2025
| if (rawSize >= BroadcastExchangeExec.MAX_BROADCAST_TABLE_BYTES) { | ||
| if (rawSize >= GlutenConfig.get.maxBroadcastTableSize) { | ||
| throw new SparkException( | ||
| s"Cannot broadcast the table that is larger than 8GB: ${rawSize >> 30} GB") |
Contributor
There was a problem hiding this comment.
should we also fix the exception msg?
Yohahaha
changed the title
|
Run Gluten Clickhouse CI on x86 |
Member
Author
|
Thank you @Yohahaha, I have addressed your revision suggestion |
Member
|
Cc @JkSelf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Port apache/spark#50327 to make max broadcast table size configurable.
Also, remove our hardcoded ones and make some custom spark build happy
How was this patch tested?