[GLUTEN-9369][DOC] Fix commands in the Gluten C++ debugging developer doc#9368
[GLUTEN-9369][DOC] Fix commands in the Gluten C++ debugging developer doc#9368PHILO-HE merged 7 commits intoapache:mainfrom
Conversation
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
dmsuehir
changed the title
dmsuehir
changed the title
dmsuehir
changed the title
docs/developers/HowTo.md
Outdated
| ``` | ||
| cd ${GLUTEN_HOME} | ||
| mvn clean package -Pspark-3.2 -Pbackends-velox -Pceleborn -Puniffle | ||
| mvn clean package -Pspark-3.2 -Pbackends-velox -Pceleborn -Puniffle -DskipTests |
There was a problem hiding this comment.
We can remove the above command, and just keep the below mvn test command.
docs/developers/HowTo.md
Outdated
| cd ${GLUTEN_HOME} | ||
| mvn clean package -Pspark-3.2 -Pbackends-velox -Pceleborn -Puniffle | ||
| mvn clean package -Pspark-3.2 -Pbackends-velox -Pceleborn -Puniffle -DskipTests | ||
| mvn test -Pspark-3.2 -Pbackends-velox -Pceleborn -pl backends-velox \ |
There was a problem hiding this comment.
Please help remove -Pbackends-velox -Pceleborn as they are not required here.
There was a problem hiding this comment.
@PHILO-HE Thank you for the review. I was able to remove -Pceleborn, but if I remove -Pbackends-velox, I get the following error:
[ERROR] [ERROR] Could not find the selected project in the reactor: backends-velox @
There was a problem hiding this comment.
@dmsuehir, sorry for my wrong comment. -Pbackends-velox must be kept. We can remove -Pceleborn -Puniffle.
There was a problem hiding this comment.
Ok, thanks. I pushed another update. Let me know if that looks ok.
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
PHILO-HE
left a comment
PHILO-HE
left a comment
There was a problem hiding this comment.
Looks good! Thanks for your fix!
* [GLUTEN-9199][VL] Fix error when creating shuffle file: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments (#9200) * [DOC] Fix broken links in documents (#9320) * [GLUTEN-9369][DOC] Fix commands in the Gluten C++ debugging developer doc (#9368) * [VL][CI] Change to use JDK-17 for Spark 3.3/3.4/3.5 tests (#9209) * [VL][CI] Bump to use ubuntu-22.04 runner (#9262) --------- Co-authored-by: Hongze Zhang <hongze.zzz123@gmail.com> Co-authored-by: PHILO-HE <philo@apache.org> Co-authored-by: Dina Suehiro Jones <dina.s.jones@intel.com> Co-authored-by: Yuan <yuanzhou@apache.org>
2 participants
What changes were proposed in this pull request?
This PR fixes commands in the developer documentation for "How to debug C++":
--build_examples=ON, I get an error "/gluten/cpp/build/velox/udf/examples/libmyudf.so does not exist"testRoundTrip(org.apache.gluten.fs.OnHeapFileSystemTest)failuregenerated-native-benchmarkfolders in the docs are outdated. They were changed here, where you can see that the references toexample_lineitem,example_orders, andexample.jsonwere removed.generic_benchmarkdoes not have default values for the json plan or input files, so they must be specified.Fixes issue #9369
How was this patch tested?
Manually tested commands from the doc.