Skip to content

Fix ColumnarToRowRemovalGuard not able to be copied#9384

Merged
yaooqinn merged 2 commits intoapache:mainfrom
yaooqinn:clone
Apr 22, 2025
Merged

Fix ColumnarToRowRemovalGuard not able to be copied#9384
yaooqinn merged 2 commits intoapache:mainfrom
yaooqinn:clone

Conversation

@yaooqinn
Copy link
Member

What changes were proposed in this pull request?

Fix a wrong constructor bug

  java.lang.IllegalStateException: Failed to copy node.
Is otherCopyArgs specified correctly for ColumnarToRowRemovalGuard.
Exception message: wrong number of arguments
ctor: public org.apache.gluten.extension.columnar.MiscColumnarRules$PreventBatchTypeMismatchInTableCache$PreventColumnarTypeMismatchInTableCache$ColumnarToRowRemovalGuard(org.apache.gluten.extension.columnar.MiscColumnarRules$PreventBatchTypeMismatchInTableCache$PreventColumnarTypeMismatchInTableCache$,org.apache.spark.sql.execution.SparkPlan)?
types: class org.apache.gluten.extension.columnar.transition.TransitionSuite$BatchToRow
args: BatchToRow VanillaBatch$
+- Range (0, 1, step=1, splits=2)
  at org.apache.spark.sql.catalyst.trees.TreeNode.makeCopy(TreeNode.scala:854)
  at org.apache.spark.sql.catalyst.trees.TreeNode.mapChildren(TreeNode.scala:781)
  at org.apache.spark.sql.catalyst.trees.TreeNode.clone(TreeNode.scala:860)
  at org.apache.gluten.extension.columnar.MiscColumnarRulesSuite.$anonfun$new$1(MiscColumnarRulesSuite.scala:32)
  at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
  at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
  at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
  at org.scalatest.Transformer.apply(Transformer.scala:22)
  at org.scalatest.Transformer.apply(Transformer.scala:20)
  at org.scalatest.funsuite.AnyFunSuiteLike$$anon$1.apply(AnyFunSuiteLike.scala:226)

How was this patch tested?

new ut

@github-actions github-actions bot added the CORE works for Gluten Core label Apr 21, 2025
@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link

Run Gluten Clickhouse CI on x86

@github-actions
Copy link

Run Gluten Clickhouse CI on x86

Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your fix.

@yaooqinn yaooqinn merged commit 82fa11d into apache:main Apr 22, 2025
47 checks passed
zhztheplayer added a commit to zhztheplayer/gluten that referenced this pull request Apr 22, 2025
@yaooqinn yaooqinn deleted the clone branch May 15, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants