Skip to content

[GOBBLIN-1354] Change homepage link in documentation for mkdocs build to pass on RTD#3194

Closed
abti wants to merge 1 commit intoapache:masterfrom
abti:master
Closed

[GOBBLIN-1354] Change homepage link in documentation for mkdocs build to pass on RTD#3194
abti wants to merge 1 commit intoapache:masterfrom
abti:master

Conversation

@abti
Copy link
Member

@abti abti commented Jan 7, 2021

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Changing to apache url didnt work last time, so changing to index.md

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Not testable locally

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #3194 (d9398c4) into master (1b31c90) will increase coverage by 37.07%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #3194       +/-   ##
=============================================
+ Coverage      9.10%   46.18%   +37.07%     
- Complexity     1726     9769     +8043     
=============================================
  Files          2017     2017               
  Lines         77221    77221               
  Branches       8568     8568               
=============================================
+ Hits           7033    35662    +28629     
+ Misses        69500    38249    -31251     
- Partials        688     3310     +2622     
Impacted Files Coverage Δ Complexity Δ
.../org/apache/gobblin/writer/AvroHdfsDataWriter.java 77.77% <0.00%> (ø) 5.00% <0.00%> (+1.00%)
...gobblin/service/monitoring/JobStatusRetriever.java 0.00% <0.00%> (ø) 2.00% <0.00%> (+2.00%)
...main/java/org/apache/gobblin/util/HadoopUtils.java 30.59% <0.00%> (+0.65%) 25.00% <0.00%> (+1.00%)
...ata/management/copy/hive/HivePartitionFileSet.java 0.93% <0.00%> (+0.93%) 1.00% <0.00%> (+1.00%)
...ain/java/org/apache/gobblin/runtime/TaskState.java 81.97% <0.00%> (+1.16%) 32.00% <0.00%> (ø%)
...in/java/org/apache/gobblin/util/FileListUtils.java 71.42% <0.00%> (+1.29%) 28.00% <0.00%> (ø%)
...ava/org/apache/gobblin/runtime/MultiConverter.java 83.60% <0.00%> (+1.63%) 9.00% <0.00%> (+1.00%)
...rg/apache/gobblin/runtime/FsDatasetStateStore.java 73.80% <0.00%> (+1.78%) 35.00% <0.00%> (+1.00%)
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 63.78% <0.00%> (+2.24%) 35.00% <0.00%> (+3.00%)
...org/apache/gobblin/yarn/GobblinYarnTaskRunner.java 2.70% <0.00%> (+2.70%) 1.00% <0.00%> (+1.00%)
... and 1061 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b31c90...d9398c4. Read the comment docs.

@asfgit asfgit closed this in c67c974 Apr 17, 2021
jhsenjaliya pushed a commit to jhsenjaliya/incubator-gobblin that referenced this pull request Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants