Skip to content

[GOBBLIN-1363] Fix minor mistakes in the Getting-Started guide#3204

Merged
aplex merged 2 commits intoapache:masterfrom
sekikn:GOBBLIN-1363
Jul 15, 2021
Merged

[GOBBLIN-1363] Fix minor mistakes in the Getting-Started guide#3204
aplex merged 2 commits intoapache:masterfrom
sekikn:GOBBLIN-1363

Conversation

@sekikn
Copy link
Copy Markdown
Contributor

@sekikn sekikn commented Jan 20, 2021

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Fixed the following mistakes/obsolete descriptions in the Getting Started document.

  • JDK version that Gobblin requires
  • Gradle task name for Findbugs
  • Broken links to other pages
  • Wrong download URL for avro-tools

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

No additional test, since it's just a documentation fix. Instead, I ran mkdocs locally and made sure the document was fixed as expected.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3204 (11f2192) into master (2fa3553) will decrease coverage by 4.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3204      +/-   ##
============================================
- Coverage     46.23%   41.95%   -4.29%     
+ Complexity     9788     8931     -857     
============================================
  Files          2019     2019              
  Lines         77439    77439              
  Branches       8602     8602              
============================================
- Hits          35807    32491    -3316     
- Misses        38300    41886    +3586     
+ Partials       3332     3062     -270     
Impacted Files Coverage Δ Complexity Δ
.../org/apache/gobblin/util/filters/HiddenFilter.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...g/apache/gobblin/cluster/HelixMessageSubTypes.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...gobblin/runtime/mapreduce/GobblinOutputFormat.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
.../gobblin/compaction/suite/CompactionSuiteBase.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-10.00%)
...obblin/compaction/source/CompactionFailedTask.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...n/cluster/event/ClusterManagerShutdownRequest.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...blin/compaction/mapreduce/RecordKeyMapperBase.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...in/compaction/action/CompactionCompleteAction.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...n/compaction/mapreduce/orc/OrcKeyDedupReducer.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-10.00%)
...n/compaction/suite/CompactionSuiteBaseFactory.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
... and 151 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fa3553...11f2192. Read the comment docs.

Copy link
Copy Markdown
Contributor

@aplex aplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aplex aplex merged commit 7d7bf14 into apache:master Jul 15, 2021
@sekikn sekikn deleted the GOBBLIN-1363 branch February 15, 2022 23:19
jack-moseley pushed a commit to jack-moseley/gobblin that referenced this pull request Aug 24, 2022
…e#3204)

Fixed the following mistakes/obsolete descriptions in the Getting Started document.

JDK version that Gobblin requires
Gradle task name for Findbugs
Broken links to other pages
Wrong download URL for avro-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants