[GOBBLIN-1387] Add function for jobcontext to access datasetstate failures#3225
Closed
Will-Lo wants to merge 1 commit intoapache:masterfrom
Closed
[GOBBLIN-1387] Add function for jobcontext to access datasetstate failures#3225Will-Lo wants to merge 1 commit intoapache:masterfrom
Will-Lo wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3225 +/- ##
============================================
- Coverage 46.18% 42.84% -3.35%
+ Complexity 9771 9203 -568
============================================
Files 2019 2030 +11
Lines 77529 78718 +1189
Branches 8608 8755 +147
============================================
- Hits 35809 33723 -2086
- Misses 38386 41785 +3399
+ Partials 3334 3210 -124 Continue to review full report at Codecov.
|
Comment on lines
+559
to
+561
| if (!this.datasetStatesByUrns.isPresent()) { | ||
| return 0; | ||
| } |
Contributor
There was a problem hiding this comment.
You could just use getDatasetStatesByUrns from this class, and it will return an empty map if not present, so this method would still correctly return 0.
Will-Lo
force-pushed
the
fix-bug-email-failures
branch
from
1f189da to
79a44fa
Compare
jhsenjaliya
pushed a commit
to jhsenjaliya/incubator-gobblin
that referenced
this pull request
Feb 25, 2021
…lures Closes apache#3225 from Will-Lo/fix-bug-email-failures
Will-Lo
added a commit
to Will-Lo/incubator-gobblin
that referenced
this pull request
Mar 5, 2021
…lures Closes apache#3225 from Will-Lo/fix-bug-email-failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Email notifications look into JOB_FAILURES_KEY, which is set by DatasetState.
JobContext's reference to it's own jobState is misleading here as it does not track dataset state failures (in terms of amounts, only if it is passed/failed).
Add a function to track the dataset state failures from jobContext
Tests
Added unit tests in JobContextTests
Commits