[GOBBLIN-1409] Expose record timestamp in kafka-1 client #3244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our use case, we need the timestamp from the broker, so we also implement isTimestampLogAppend and a kafka-1 specific method, getTimestampType, to let us check the TimestampType in all cases.
Contributor
Author
|
Apologies for the initial hiccup, I think I straightened it out. cc @ZihanLi58 |
Codecov Report
@@ Coverage Diff @@
## master #3244 +/- ##
============================================
- Coverage 46.40% 9.03% -37.38%
+ Complexity 9940 1737 -8203
============================================
Files 2030 2030
Lines 78783 78786 +3
Branches 8765 8766 +1
============================================
- Hits 36561 7117 -29444
- Misses 38815 70973 +32158
+ Partials 3407 696 -2711 Continue to review full report at Codecov.
|
ZihanLi58
approved these changes
Mar 15, 2021
Contributor
ZihanLi58
left a comment
ZihanLi58
left a comment
There was a problem hiding this comment.
+1 LGTM. @autumnust Can you help merge?
Contributor
Author
|
Just a gentle bump here, we're wondering about rough timelines of PRs as we strategize about our deployment of gobblin. Any info is appreciated. |
Contributor
|
@milimetric : thanks for the contribution and sorry for the delay in merging this in! |
Contributor
Author
|
My pleasure! Thank you for the guidance.
…On Fri, Apr 9, 2021 at 22:58 Shirshanka Das ***@***.***> wrote:
@milimetric <https://github.com/milimetric> : thanks for the contribution
and sorry for the delay in merging this in!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3244 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5UUBDXVH3DDSOQMBD2PLTH65FDANCNFSM4ZCYONKA>
.
|
jhsenjaliya
pushed a commit
to jhsenjaliya/incubator-gobblin
that referenced
this pull request
Jun 7, 2021
In our use case, we need the timestamp from the broker, so we also implement isTimestampLogAppend and a kafka-1 specific method, getTimestampType, to let us check the TimestampType in all cases. Closes apache#3244 from milimetric/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
This is my first PR, please do point out any mistakes or omissions.
JIRA
GOBBLIN-1409
Description
When consuming from Kafka, we need the kafka timestamp and timestamp type. This change implements the necessary methods.
Tests