-
Notifications
You must be signed in to change notification settings - Fork 748
[GOBBLIN-1410] Bump lombok to 1.18.16 for compatibility with Java 11 #3245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@htran1 please review/merge, thanks |
49e524a to
918922f
Compare
autumnust
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #3245 +/- ##
============================================
+ Coverage 46.40% 46.43% +0.03%
+ Complexity 9947 9941 -6
============================================
Files 2030 2030
Lines 78783 78877 +94
Branches 8765 8788 +23
============================================
+ Hits 36558 36630 +72
- Misses 38821 38832 +11
- Partials 3404 3415 +11 Continue to review full report at Codecov.
|
918922f to
c937dbc
Compare
Closes apache#3245 from jack-moseley/lombok-version
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Lombok version 1.18.10 is required for compatibility with Java 11, so bumping it because there are downstream consumers of gobblin that are migrating to java 11 that require it.
Tests
./gradlewbuild passedCommits