Skip to content

Conversation

@jack-moseley
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Lombok version 1.18.10 is required for compatibility with Java 11, so bumping it because there are downstream consumers of gobblin that are migrating to java 11 that require it.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    ./gradlew build passed

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@jack-moseley
Copy link
Contributor Author

@htran1 please review/merge, thanks

@jack-moseley jack-moseley force-pushed the lombok-version branch 2 times, most recently from 49e524a to 918922f Compare March 16, 2021 23:41
@jack-moseley jack-moseley changed the title [GOBBLIN-1410] Bump lombok to 1.18.10 for compatibility with Java 11 [GOBBLIN-1410] Bump lombok to 1.18.16 for compatibility with Java 11 Mar 16, 2021
Copy link
Contributor

@autumnust autumnust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hanghangliu
Copy link
Contributor

LGTM

@codecov-io
Copy link

codecov-io commented Mar 17, 2021

Codecov Report

Merging #3245 (918922f) into master (30bc46d) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3245      +/-   ##
============================================
+ Coverage     46.40%   46.43%   +0.03%     
+ Complexity     9947     9941       -6     
============================================
  Files          2030     2030              
  Lines         78783    78877      +94     
  Branches       8765     8788      +23     
============================================
+ Hits          36558    36630      +72     
- Misses        38821    38832      +11     
- Partials       3404     3415      +11     
Impacted Files Coverage Δ Complexity Δ
...a/org/apache/gobblin/util/limiter/NoopLimiter.java 40.00% <0.00%> (-20.00%) 2.00% <0.00%> (-1.00%)
...lin/data/management/copy/FileAwareInputStream.java 72.72% <0.00%> (-9.10%) 4.00% <0.00%> (ø%)
...lin/util/filesystem/FileSystemInstrumentation.java 85.71% <0.00%> (-7.15%) 3.00% <0.00%> (-1.00%)
...obblin/data/management/copy/CopyConfiguration.java 80.43% <0.00%> (-4.57%) 14.00% <0.00%> (ø%)
...a/org/apache/gobblin/hive/spec/SimpleHiveSpec.java 75.67% <0.00%> (-4.33%) 7.00% <0.00%> (ø%)
...ava/org/apache/gobblin/fsm/FiniteStateMachine.java 73.48% <0.00%> (-3.04%) 18.00% <0.00%> (-3.00%)
...compaction/verify/CompactionTimeRangeVerifier.java 86.88% <0.00%> (-1.64%) 11.00% <0.00%> (-1.00%)
.../org/apache/gobblin/metrics/RootMetricContext.java 78.12% <0.00%> (-1.57%) 15.00% <0.00%> (-1.00%)
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 63.46% <0.00%> (-0.33%) 34.00% <0.00%> (-1.00%)
...rg/apache/gobblin/util/ProxiedFileSystemCache.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30bc46d...918922f. Read the comment docs.

@asfgit asfgit closed this in 6f3e078 Mar 18, 2021
jhsenjaliya pushed a commit to jhsenjaliya/incubator-gobblin that referenced this pull request Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants