[GOBBLIN-1426] let child classes use SalesforceConnector code#3262
Closed
arjun4084346 wants to merge 1 commit intoapache:masterfrom
Closed
[GOBBLIN-1426] let child classes use SalesforceConnector code#3262arjun4084346 wants to merge 1 commit intoapache:masterfrom
arjun4084346 wants to merge 1 commit intoapache:masterfrom
Conversation
autumnust
approved these changes
Apr 15, 2021
jhsenjaliya
pushed a commit
to jhsenjaliya/incubator-gobblin
that referenced
this pull request
Jun 7, 2021
Closes apache#3262 from arjun4084346/codeReuse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Static method
isPasswordGrantin SalesforceConnector is private, so child classes cannot use it.This PR will make it protected so child classes can use it.
Tests
very trivial changes; do not require unit tests
Commits