Skip to content

[GOBBLIN-1426] let child classes use SalesforceConnector code#3262

Closed
arjun4084346 wants to merge 1 commit intoapache:masterfrom
arjun4084346:codeReuse
Closed

[GOBBLIN-1426] let child classes use SalesforceConnector code#3262
arjun4084346 wants to merge 1 commit intoapache:masterfrom
arjun4084346:codeReuse

Conversation

@arjun4084346
Copy link
Contributor

@arjun4084346 arjun4084346 commented Apr 15, 2021

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Static method isPasswordGrant in SalesforceConnector is private, so child classes cannot use it.
    This PR will make it protected so child classes can use it.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    very trivial changes; do not require unit tests

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@arjun4084346 arjun4084346 changed the title let child classes use SalesforceConnector code [GOBBLIN-1426] let child classes use SalesforceConnector code Apr 15, 2021
Copy link
Contributor

@htran1 htran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@asfgit asfgit closed this in 22b00ef Apr 15, 2021
jhsenjaliya pushed a commit to jhsenjaliya/incubator-gobblin that referenced this pull request Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments