Clear flow event after cancel#3271
Merged
autumnust merged 4 commits intoapache:masterfrom Apr 26, 2021
Merged
Conversation
added 2 commits
April 23, 2021 11:31
Codecov Report
@@ Coverage Diff @@
## master #3271 +/- ##
============================================
- Coverage 46.47% 8.99% -37.48%
+ Complexity 9996 1739 -8257
============================================
Files 2036 2036
Lines 79200 79201 +1
Branches 8834 8834
============================================
- Hits 36809 7127 -29682
- Misses 38971 71372 +32401
+ Partials 3420 702 -2718 Continue to review full report at Codecov.
|
Will-Lo
approved these changes
Apr 23, 2021
Contributor
|
@jack-moseley could you take a look? |
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
Show resolved
Hide resolved
umustafi
force-pushed
the
clearFlowEventAfterCancel
branch
from
d888aca to
4dafa68
Compare
jack-moseley
approved these changes
Apr 26, 2021
jhsenjaliya
pushed a commit
to jhsenjaliya/incubator-gobblin
that referenced
this pull request
Jun 7, 2021
* cleared flow event after cancelled job to allow resume event status to work * moved clearing of FlowEvent to occur before dags are cleaned up to avoid regression * added comment to clarify nullification of FlowEvent field Co-authored-by: Urmi Mustafi <umustafi@umustafi-mn1.linkedin.biz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
After the job emits cancel event it needs to have the Flow Event field cleared, so it can have its job status marked as Resumed later.
Tests
Commits