Skip to content

[GOBBLIN-1456] do not remove spec on update#3295

Closed
arjun4084346 wants to merge 1 commit intoapache:masterfrom
arjun4084346:fix_update
Closed

[GOBBLIN-1456] do not remove spec on update#3295
arjun4084346 wants to merge 1 commit intoapache:masterfrom
arjun4084346:fix_update

Conversation

@arjun4084346
Copy link
Copy Markdown
Contributor

@arjun4084346 arjun4084346 commented Jun 2, 2021

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
@jack-moseley @Will-Lo please review

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    GobblinServiceJobScheduler update logic first deletes the spec and then adds it back. I think it is unnecessary and also create an issue. During delete spec it calls Orchestrator remove code and that sends a delete call to spec executor, which is wrong, because flow spec is actually not intended to be deleted. On cluster side, it is forcing a state store deletion.
    This PR will remove the delete part.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    trivial changes. tested locally

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 2, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.55%. Comparing base (557f255) to head (4f225a2).
⚠️ Report is 798 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3295      +/-   ##
============================================
- Coverage     46.55%   46.55%   -0.01%     
+ Complexity    10036    10031       -5     
============================================
  Files          2037     2037              
  Lines         79294    79290       -4     
  Branches       8843     8843              
============================================
- Hits          36919    36911       -8     
- Misses        38950    38952       +2     
- Partials       3425     3427       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arjun4084346 arjun4084346 changed the title do not remove spec on update [GOBBLIN-1456] do not remove spec on update Jun 2, 2021
@arjun4084346
Copy link
Copy Markdown
Contributor Author

@sv2000 please merge

Copy link
Copy Markdown
Contributor

@sv2000 sv2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

@asfgit asfgit closed this in 5199078 Jun 4, 2021
jhsenjaliya pushed a commit to jhsenjaliya/incubator-gobblin that referenced this pull request Jun 7, 2021
Closes apache#3295 from arjun4084346/fix_update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants