[GOBBLIN-1456] do not remove spec on update#3295
Closed
arjun4084346 wants to merge 1 commit intoapache:masterfrom
Closed
[GOBBLIN-1456] do not remove spec on update#3295arjun4084346 wants to merge 1 commit intoapache:masterfrom
arjun4084346 wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3295 +/- ##
============================================
- Coverage 46.55% 46.55% -0.01%
+ Complexity 10036 10031 -5
============================================
Files 2037 2037
Lines 79294 79290 -4
Branches 8843 8843
============================================
- Hits 36919 36911 -8
- Misses 38950 38952 +2
- Partials 3425 3427 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-moseley
approved these changes
Jun 2, 2021
Will-Lo
approved these changes
Jun 3, 2021
Contributor
Author
|
@sv2000 please merge |
jhsenjaliya
pushed a commit
to jhsenjaliya/incubator-gobblin
that referenced
this pull request
Jun 7, 2021
Closes apache#3295 from arjun4084346/fix_update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
@jack-moseley @Will-Lo please review
JIRA
Description
GobblinServiceJobScheduler update logic first deletes the spec and then adds it back. I think it is unnecessary and also create an issue. During delete spec it calls Orchestrator remove code and that sends a delete call to spec executor, which is wrong, because flow spec is actually not intended to be deleted. On cluster side, it is forcing a state store deletion.
This PR will remove the delete part.
Tests
trivial changes. tested locally
Commits