[GOBBLIN-1463] Remove pentaho dependency#3303
Merged
autumnust merged 2 commits intoapache:masterfrom Jun 9, 2021
Merged
Conversation
aplex
reviewed
Jun 9, 2021
Contributor
aplex
left a comment
There was a problem hiding this comment.
LTGM. Don't forget to add motivation for the change to commit message/PR description
Codecov Report
@@ Coverage Diff @@
## master #3303 +/- ##
============================================
- Coverage 46.50% 42.99% -3.51%
+ Complexity 10041 9313 -728
============================================
Files 2041 2041
Lines 79349 79349
Branches 8845 8845
============================================
- Hits 36898 34117 -2781
- Misses 39020 41995 +2975
+ Partials 3431 3237 -194
Continue to review full report at Codecov.
|
Contributor
Author
|
@aplex Ahh unfortunately it looks like hive-exec version also has a dependency on pentaho...need to think of how to prevent that as well. |
8e1fca4 to
7d8ad2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Pentaho's library for aggdesigner is used in tests. https://mvnrepository.com/artifact/org.pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde However, the nexus repository frequently goes down and is unreliable.
Proposal to move to a newer version of aggdesigner hosted on maven central, similar to calcite https://issues.apache.org/jira/browse/CALCITE-1474.
Tests
Commits