[GOBBLIN-1480] Cleanup unused imports and enable checkstyle for them#3320
Merged
autumnust merged 1 commit intoapache:masterfrom Jul 1, 2021
Merged
[GOBBLIN-1480] Cleanup unused imports and enable checkstyle for them#3320autumnust merged 1 commit intoapache:masterfrom
autumnust merged 1 commit intoapache:masterfrom
Conversation
aplex
force-pushed
the
checkstyle-import-fixes
branch
from
575e5a3 to
9044b4c
Compare
arjun4084346
approved these changes
Jun 23, 2021
Contributor
arjun4084346
left a comment
arjun4084346
left a comment
There was a problem hiding this comment.
Are you planning to add rest of the checkstyle configurations in another PR?
Codecov Report
@@ Coverage Diff @@
## master #3320 +/- ##
============================================
- Coverage 46.50% 42.83% -3.67%
+ Complexity 10041 1931 -8110
============================================
Files 2041 394 -1647
Lines 79349 16870 -62479
Branches 8845 2072 -6773
============================================
- Hits 36898 7226 -29672
+ Misses 39020 8846 -30174
+ Partials 3431 798 -2633
Continue to review full report at Codecov.
|
aplex
force-pushed
the
checkstyle-import-fixes
branch
3 times, most recently
from
39b2dea to
c06d419
Compare
Previously, checkstyle was configured to check only a small subset of things, and imports were not one of them. As a result, reviewers spend their time commenting on code style, when it can be fully verified automatically by CI job. We enable unused/redundant import checks, and fix existing issues, so that the build could complete successfully. The only relevant change is in checkstyle.xml, all other files where changed by IntelliJ "optimize imports" function. For most files it just removed unused imports, but some of them had imports incorrectly ordered, and IntelliJ fixed that as well.
aplex
force-pushed
the
checkstyle-import-fixes
branch
from
c06d419 to
7491c2d
Compare
Contributor
|
@aplex Thanks for this clean up PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, checkstyle was configured to check only a small subset of
things, and imports were not one of them. As a result, reviewers spend
their time commenting on code style, when it can be fully verified
automatically by CI job.
We enable unused/redundant import checks, and fix existing issues, so
that the build could complete successfully.
The only relevant change is in checkstyle.xml, all other files where
changed by IntelliJ "optimize imports" function. For most files it
just removed unused imports, but some of them had imports incorrectly
ordered, and IntelliJ fixed that as well.
https://issues.apache.org/jira/browse/GOBBLIN-1480