[GOBBLIN-1491] Add option to mark up/down D2 servers for gobblin service on leadership change#3333
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3333 +/- ##
============================================
- Coverage 46.55% 46.54% -0.02%
+ Complexity 10138 10136 -2
============================================
Files 2051 2052 +1
Lines 79547 79557 +10
Branches 8880 8882 +2
============================================
- Hits 37036 37028 -8
- Misses 39086 39096 +10
- Partials 3425 3433 +8
Continue to review full report at Codecov.
|
aplex
reviewed
Jul 16, 2021
aplex
approved these changes
Jul 23, 2021
Contributor
aplex
left a comment
There was a problem hiding this comment.
LGTM. Can you fix the build issues? I'll merge it after.
phet
pushed a commit
to phet/gobblin
that referenced
this pull request
Aug 9, 2021
…ice on leadership change (apache#3333) Currently, D2 servers are started on all hosts at the time of service start. This change will allow using D2 delayed start, then marking up/down the servers when a host becomes the master/slave respectively. This means only the master will be announced to D2, so all requests will be routed to it. The logic for markup is linkedin specific so must be implemented in internal code.
jack-moseley
added a commit
to jack-moseley/gobblin
that referenced
this pull request
Aug 24, 2022
…ice on leadership change (apache#3333) Currently, D2 servers are started on all hosts at the time of service start. This change will allow using D2 delayed start, then marking up/down the servers when a host becomes the master/slave respectively. This means only the master will be announced to D2, so all requests will be routed to it. The logic for markup is linkedin specific so must be implemented in internal code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Currently, D2 servers are started on all hosts at the time of service start. This change will allow using D2 delayed start, then marking up/down the servers when a host becomes the master/slave respectively. This means only the master will be announced to D2, so all requests will be routed to it.
The logic for markup is linkedin specific so must be implemented in internal code.
Tests
Commits