[GOBBLIN-1501] Documentation + Code Cleaning for IcebergMetadataWriter #3347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
This PR mostly adds documentation, renaming and fixing typo in the
gobblin-icbergmodule, with extra focus onIcebergMetadataWriterfor:Transactionobject is initialized as it is shared in many different places.AppendFilesandDeleteFilesobject. All these changes inTableMetadataobject.IOExceptionin the method signature wherever they are not required.Tests
This PR doesn't add or delete any of the functionality so pass all unit tests should be sufficient.
Commits