Skip to content

GOBBLIN-1523: Change logging of live instances in Gobblin cluster to debug level#3374

Merged
sv2000 merged 1 commit intoapache:masterfrom
sv2000:logLiveInstances
Aug 24, 2021
Merged

GOBBLIN-1523: Change logging of live instances in Gobblin cluster to debug level#3374
sv2000 merged 1 commit intoapache:masterfrom
sv2000:logLiveInstances

Conversation

@sv2000
Copy link
Copy Markdown
Contributor

@sv2000 sv2000 commented Aug 23, 2021

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Currently, the live instances are logged at info level. This can result in a ton of uninformative logs in a production deployment, making debugging issues hard.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Existing tests.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 23, 2021

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.42%. Comparing base (44c7316) to head (e058e09).
⚠️ Report is 715 commits behind head on master.

Files with missing lines Patch % Lines
...ache/gobblin/cluster/GobblinHelixMultiManager.java 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3374      +/-   ##
============================================
- Coverage     46.43%   46.42%   -0.02%     
+ Complexity    10159    10156       -3     
============================================
  Files          2056     2056              
  Lines         80080    80081       +1     
  Branches       8947     8948       +1     
============================================
- Hits          37186    37177       -9     
- Misses        39448    39456       +8     
- Partials       3446     3448       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@autumnust autumnust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sv2000 sv2000 merged commit 45c9831 into apache:master Aug 24, 2021
jack-moseley pushed a commit to jack-moseley/gobblin that referenced this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants