GOBBLIN-1524: Limit the number of container launch threads used by YarnService#3375
Merged
sv2000 merged 1 commit intoapache:masterfrom Aug 24, 2021
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3375 +/- ##
============================================
- Coverage 46.43% 46.42% -0.01%
+ Complexity 10159 10155 -4
============================================
Files 2056 2056
Lines 80080 80083 +3
Branches 8947 8947
============================================
- Hits 37186 37181 -5
- Misses 39448 39453 +5
- Partials 3446 3449 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-moseley
pushed a commit
to jack-moseley/gobblin
that referenced
this pull request
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Currently, there are no limits on the number of threads used, which can result in OOMEs with "unable to create a new native thread". This PR makes the number of threads configurable with a default of 1024.
Tests
Trivial change. Existing tests should be sufficient.
Commits