GOBBLIN-1566:fix resource leak due to Files.walk and replace guava's …#3417
Open
lujiefsi wants to merge 2 commits intoapache:masterfrom
Open
GOBBLIN-1566:fix resource leak due to Files.walk and replace guava's …#3417lujiefsi wants to merge 2 commits intoapache:masterfrom
lujiefsi wants to merge 2 commits intoapache:masterfrom
Conversation
…Files.createTempDir()
arjun4084346
approved these changes
Oct 28, 2021
ZihanLi58
reviewed
Nov 2, 2021
| public static String getTempDirectory() throws IOException { | ||
| File tempDirBase = new File(System.getProperty("java.io.tmpdir")); | ||
| File tmpDirectory = Files.createTempDirectory( | ||
| tempDirBase.toPath(), System.currentTimeMillis() + "-").toFile(); |
Contributor
There was a problem hiding this comment.
Why do we still want add "-" there? maybe change it to "-Gobblin"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/GOBBLIN-1566