Skip to content

[GOBBLIN-1589] add FileContextFactory to cache FileContext instances#3442

Closed
arjun4084346 wants to merge 1 commit intoapache:masterfrom
arjun4084346:FileContextFactory
Closed

[GOBBLIN-1589] add FileContextFactory to cache FileContext instances#3442
arjun4084346 wants to merge 1 commit intoapache:masterfrom
arjun4084346:FileContextFactory

Conversation

@arjun4084346
Copy link
Copy Markdown
Contributor

@arjun4084346 arjun4084346 commented Dec 8, 2021

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
@sv2000 @phet please review

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    provide a way to cache FileContext. This is needed because unlike FileSystem, FileContext is not cached and thus every file being copied in distcp creates a new object of FileContext. This often causes OOM errors.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    added a unit test in FileContextFactoryTest

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@arjun4084346 arjun4084346 changed the title add FileContextFactory to cache FileContext instances [GOBBLIN-1589] add FileContextFactory to cache FileContext instances Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant