Skip to content

remove dependency on 'org.kt3k.gradle.plugin:coveralls-gradle-plugin:…#3553

Closed
umustafi wants to merge 2 commits intoapache:masterfrom
umustafi:removeFailingGradlePlugin
Closed

remove dependency on 'org.kt3k.gradle.plugin:coveralls-gradle-plugin:…#3553
umustafi wants to merge 2 commits intoapache:masterfrom
umustafi:removeFailingGradlePlugin

Conversation

@umustafi
Copy link
Copy Markdown
Contributor

@umustafi umustafi commented Sep 8, 2022

…1.0.2'

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #3553 (934feef) into master (fa97ff5) will decrease coverage by 1.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3553      +/-   ##
============================================
- Coverage     46.70%   45.64%   -1.07%     
+ Complexity    10484     9199    -1285     
============================================
  Files          2089     1830     -259     
  Lines         81863    72898    -8965     
  Branches       9123     8151     -972     
============================================
- Hits          38236    33272    -4964     
+ Misses        40091    36571    -3520     
+ Partials       3536     3055     -481     
Impacted Files Coverage Δ
...he/gobblin/source/PartitionAwareFileRetriever.java 48.14% <0.00%> (-7.41%) ⬇️
.../java/org/apache/gobblin/cluster/SleepingTask.java 39.39% <0.00%> (-6.07%) ⬇️
...a/org/apache/gobblin/cluster/GobblinHelixTask.java 60.21% <0.00%> (-2.16%) ⬇️
.../apache/gobblin/service/FlowConfigsV2Resource.java
.../service/monitoring/KafkaAvroJobStatusMonitor.java
...e/modules/orchestration/MysqlUserQuotaManager.java
...lin/service/modules/db/ServiceDatabaseManager.java
...blin/service/modules/orchestration/DagManager.java
...apache/gobblin/fork/CopyNotSupportedException.java
...he/gobblin/restli/throttling/PoliciesResource.java
... and 256 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@Will-Lo Will-Lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the timely fix

arjun4084346 and others added 2 commits September 8, 2022 14:05
fix unit test and address review comments
address review comments
merge conflicts
@umustafi umustafi force-pushed the removeFailingGradlePlugin branch from 934feef to a9c0583 Compare September 8, 2022 21:07
@umustafi umustafi marked this pull request as draft September 8, 2022 21:09
@umustafi umustafi closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants