remove dependency on 'org.kt3k.gradle.plugin:coveralls-gradle-plugin:…#3553
Closed
umustafi wants to merge 2 commits intoapache:masterfrom
Closed
remove dependency on 'org.kt3k.gradle.plugin:coveralls-gradle-plugin:…#3553umustafi wants to merge 2 commits intoapache:masterfrom
umustafi wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3553 +/- ##
============================================
- Coverage 46.70% 45.64% -1.07%
+ Complexity 10484 9199 -1285
============================================
Files 2089 1830 -259
Lines 81863 72898 -8965
Branches 9123 8151 -972
============================================
- Hits 38236 33272 -4964
+ Misses 40091 36571 -3520
+ Partials 3536 3055 -481 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Will-Lo
approved these changes
Sep 8, 2022
Contributor
Will-Lo
left a comment
There was a problem hiding this comment.
Thanks for the timely fix
fix unit test and address review comments address review comments merge conflicts
934feef to
a9c0583
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…1.0.2'
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Tests
Commits