Skip to content

Conversation

@ZihanLi58
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Change the property.contains to property.containsKey() method

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    unit test

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #3604 (879bad5) into master (c3d1ba8) will increase coverage by 2.48%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3604      +/-   ##
============================================
+ Coverage     46.89%   49.37%   +2.48%     
+ Complexity    10673     9198    -1475     
============================================
  Files          2120     1741     -379     
  Lines         83080    67491   -15589     
  Branches       9254     7715    -1539     
============================================
- Hits          38962    33327    -5635     
+ Misses        40548    31045    -9503     
+ Partials       3570     3119     -451     
Impacted Files Coverage Δ
...a/org/apache/gobblin/cluster/GobblinHelixTask.java 60.21% <0.00%> (-23.66%) ⬇️
...modules/flowgraph/datanodes/hive/HiveDataNode.java 40.00% <0.00%> (-23.16%) ⬇️
...a/org/apache/gobblin/util/limiter/NoopLimiter.java 40.00% <0.00%> (-20.00%) ⬇️
...he/gobblin/source/PartitionAwareFileRetriever.java 48.14% <0.00%> (-7.41%) ⬇️
...lin/util/filesystem/FileSystemInstrumentation.java 92.85% <0.00%> (-7.15%) ⬇️
...e/gobblin/service/monitoring/GitConfigMonitor.java 95.23% <0.00%> (-4.77%) ⬇️
...c/main/java/org/apache/gobblin/util/PathUtils.java 12.00% <0.00%> (-1.34%) ⬇️
.../apache/gobblin/runtime/api/JobExecutionState.java 79.43% <0.00%> (-0.94%) ⬇️
...e/modules/orchestration/MysqlUserQuotaManager.java 47.00% <0.00%> (-0.16%) ⬇️
...rg/apache/gobblin/runtime/AbstractJobLauncher.java 58.68% <0.00%> (ø)
... and 394 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ZihanLi58 ZihanLi58 merged commit e5f4047 into apache:master Nov 19, 2022
phet pushed a commit to phet/gobblin that referenced this pull request Dec 3, 2022
* address comments

* use connectionmanager when httpclient is not cloesable

* [GOBBLIN-1741] Create manifest based dataset finder

* [GOBBLIN-1745] Fix bug in SimpleKafkaSpecProducer

* Revert "[GOBBLIN-1741] Create manifest based dataset finder"

This reverts commit 37c0c9f.

Co-authored-by: Zihan Li <zihli@zihli-mn2.linkedin.biz>
phet added a commit to phet/gobblin that referenced this pull request Dec 5, 2022
* upstream/master:
  [GOBBLIN-1747] add job.name and job.id to kafka and compaction workunits (apache#3607)
  [GOBBLIN-1746] Add fs.uri to FsDatasetDescriptor to support copy between volumes in GaaS (apache#3605)
  [GOBBLIN-1743] Ensure GobblinTaskRunner works without Yarn use (apache#3602)
  [GOBBLIN-1745] Fix bug in SimpleKafkaSpecProducer (apache#3604)
  [GOBBLIN-1739]Define Datanodes and Dataset Descriptor for Iceberg (apache#3596)
  do not close DestinationDatasetHandlerService prematurely (apache#3601)
  [GOBBLIN-1720]Add ancestors owner permissions preservations for iceberg distcp (apache#3577)
  [HOTFIX] Fix checkstyleMain (apache#3600)
  [GOBBLIN-1736] Add metrics for change stream monitor and mysql quota manager (apache#3593)
  [GOBBLIN-1737] Fix bug when using mysql user quota manager (apache#3595)
  Correct a log line and GTE with currect number of total task count (apache#3591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants