Skip to content

Conversation

@Will-Lo
Copy link
Contributor

@Will-Lo Will-Lo commented Jan 6, 2023

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Updates the slack link. It should never expire this time.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #3620 (1a73ff1) into master (5d1461f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3620   +/-   ##
=========================================
  Coverage     46.54%   46.55%           
+ Complexity    10646    10644    -2     
=========================================
  Files          2129     2129           
  Lines         83291    83291           
  Branches       9279     9279           
=========================================
+ Hits          38768    38773    +5     
+ Misses        40960    40954    -6     
- Partials       3563     3564    +1     
Impacted Files Coverage Δ
...lin/elasticsearch/writer/FutureCallbackHolder.java 61.42% <0.00%> (-1.43%) ⬇️
...a/management/copy/publisher/CopyDataPublisher.java 74.17% <0.00%> (-1.33%) ⬇️
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 62.53% <0.00%> (+0.30%) ⬆️
.../apache/gobblin/runtime/api/JobExecutionState.java 80.37% <0.00%> (+0.93%) ⬆️
...a/org/apache/gobblin/cluster/GobblinHelixTask.java 66.66% <0.00%> (+2.15%) ⬆️
...lin/restli/throttling/ZookeeperLeaderElection.java 72.22% <0.00%> (+2.22%) ⬆️
.../gobblin/cluster/GobblinHelixTaskStateTracker.java 68.75% <0.00%> (+6.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Will-Lo Will-Lo merged commit 36e92fb into apache:master Jan 9, 2023
phet added a commit to phet/gobblin that referenced this pull request Jan 18, 2023
* upstream/master:
  upgrade hadoop version (apache#3621)
  [GOBBLIN-1744] Improve handling of null value edge cases when querying Helix (apache#3603)
  Handle d2 markup case when not only announcing leader (apache#3622)
  Update Gobblin OSS Slack channel link to a never-expire link (apache#3620)
  [GOBBLIN-1750] Add schemas for observability events in GaaS (apache#3610)
  [GOBBLIN-1757]Refactor manifest, add reader/writer and iterator for efficient reading (apache#3618)
  Disable flaky HiveMaterializerTest on CI/CD (apache#3619)
  [GOBBLIN-1754] Fixes for mysql store change monitors (apache#3615)
  [GOBBLIN-1756] Fix the issue that we skipping flows for multihop jobs (apache#3617)
  [GOBBLIN-1752] Fix race condition where FSTemplateCatalog would update at the same t… (apache#3612)
  [GOBBLIN-1753] Migrate DB connection pool from o.a.commons.dbcp/dbcp2 to HikariCP (apache#3613)
  [GOBBLIN-1748] Add logs to debug multi-hop flows creation, progression, and cleanup (apache#3608)
@Will-Lo Will-Lo deleted the update-slack-invite-link branch September 26, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants