Skip to content

Conversation

@meethngala
Copy link
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

As part of supporting multiple Iceberg Catalogs, I am defining generic IcebergDataNode that will represent an Iceberg node in the Flow Graph for any type of Iceberg Catalog and not just Hive. Below are the changes added as part of this PR:

  • Here are some details about my PR, including screenshots (if applicable):
  • Added IcebergDataNode which takes a catalog Uri

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
  • Added unit tests

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #3646 (f9c6060) into master (26fd244) will decrease coverage by 0.02%.
The diff coverage is 63.63%.

@@             Coverage Diff              @@
##             master    #3646      +/-   ##
============================================
- Coverage     46.61%   46.60%   -0.02%     
  Complexity    10712    10712              
============================================
  Files          2133     2134       +1     
  Lines         83637    83648      +11     
  Branches       9300     9301       +1     
============================================
- Hits          38986    38981       -5     
- Misses        41095    41108      +13     
- Partials       3556     3559       +3     
Impacted Files Coverage Δ
...s/flowgraph/datanodes/iceberg/IcebergDataNode.java 63.63% <63.63%> (ø)
...ava/org/apache/gobblin/fsm/FiniteStateMachine.java 73.48% <0.00%> (-3.04%) ⬇️
...lin/restli/throttling/ZookeeperLeaderElection.java 70.00% <0.00%> (-2.23%) ⬇️
...a/org/apache/gobblin/cluster/GobblinHelixTask.java 64.51% <0.00%> (-2.16%) ⬇️
...lin/elasticsearch/writer/FutureCallbackHolder.java 61.42% <0.00%> (-1.43%) ⬇️
.../modules/scheduler/GobblinServiceJobScheduler.java 63.03% <0.00%> (-1.43%) ⬇️
...main/java/org/apache/gobblin/util/HadoopUtils.java 30.29% <0.00%> (-0.66%) ⬇️
...lin/util/filesystem/FileSystemInstrumentation.java 100.00% <0.00%> (+7.14%) ⬆️
...a/org/apache/gobblin/util/limiter/NoopLimiter.java 60.00% <0.00%> (+20.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Will-Lo Will-Lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Will-Lo Will-Lo merged commit f4f996f into apache:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants