Skip to content

[GOBBLIN-1913] Remove extra information from scheduler trigger tracing logs#3779

Merged
Will-Lo merged 2 commits intoapache:masterfrom
umustafi:cleanUpSchedulerTriggerTracingLogs
Sep 21, 2023
Merged

[GOBBLIN-1913] Remove extra information from scheduler trigger tracing logs#3779
Will-Lo merged 2 commits intoapache:masterfrom
umustafi:cleanUpSchedulerTriggerTracingLogs

Conversation

@umustafi
Copy link
Copy Markdown
Contributor

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    We've determined the correct timezone for timestamp conversions in the scheduler trigger tracing logs. Remove unnecessary information to make log easier to read. 

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

+ "localTZTriggerTime: {} localTZNextTriggerTime: {}- Job triggered by scheduler", triggerTimeMillis,
utcDateAsUTCEpochMillis(trigger.getNextFireTime()), localTZTriggerTimeMillis,
systemDefaultZoneDateAsUTCEpochMillis(trigger.getNextFireTime()));
_log.info(jobSchedulerTracePrefixBuilder(jobProps) + "triggerTime (in UTC): {} nextTriggerTime (in UTC): {} -"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a space before '-'?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space is on the next line the diff isn't showing it correctly

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 21, 2023

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.30%. Comparing base (a289613) to head (00ae0ea).
⚠️ Report is 351 commits behind head on master.

Files with missing lines Patch % Lines
.../modules/scheduler/GobblinServiceJobScheduler.java 42.85% 4 Missing ⚠️
...vice/modules/orchestration/FlowTriggerHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3779      +/-   ##
============================================
- Coverage     47.30%   47.30%   -0.01%     
+ Complexity    10953    10950       -3     
============================================
  Files          2152     2152              
  Lines         85114    85110       -4     
  Branches       9452     9452              
============================================
- Hits          40263    40261       -2     
+ Misses        41197    41196       -1     
+ Partials       3654     3653       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Will-Lo Will-Lo merged commit c888881 into apache:master Sep 21, 2023
gautamguptabasant pushed a commit to gautamguptabasant/gobblin that referenced this pull request Sep 21, 2023
…g logs (apache#3779)

* Remove extra timestamps

* Put UTC info in prefix

---------

Co-authored-by: Urmi Mustafi <umustafi@linkedin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants