[GOBBLIN-1913] Remove extra information from scheduler trigger tracing logs#3779
Merged
Will-Lo merged 2 commits intoapache:masterfrom Sep 21, 2023
Merged
Conversation
phet
reviewed
Sep 19, 2023
...rvice/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
Outdated
Show resolved
Hide resolved
| + "localTZTriggerTime: {} localTZNextTriggerTime: {}- Job triggered by scheduler", triggerTimeMillis, | ||
| utcDateAsUTCEpochMillis(trigger.getNextFireTime()), localTZTriggerTimeMillis, | ||
| systemDefaultZoneDateAsUTCEpochMillis(trigger.getNextFireTime())); | ||
| _log.info(jobSchedulerTracePrefixBuilder(jobProps) + "triggerTime (in UTC): {} nextTriggerTime (in UTC): {} -" |
Contributor
Author
There was a problem hiding this comment.
space is on the next line the diff isn't showing it correctly
phet
approved these changes
Sep 19, 2023
Will-Lo
approved these changes
Sep 21, 2023
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3779 +/- ##
============================================
- Coverage 47.30% 47.30% -0.01%
+ Complexity 10953 10950 -3
============================================
Files 2152 2152
Lines 85114 85110 -4
Branches 9452 9452
============================================
- Hits 40263 40261 -2
+ Misses 41197 41196 -1
+ Partials 3654 3653 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gautamguptabasant
pushed a commit
to gautamguptabasant/gobblin
that referenced
this pull request
Sep 21, 2023
…g logs (apache#3779) * Remove extra timestamps * Put UTC info in prefix --------- Co-authored-by: Urmi Mustafi <umustafi@linkedin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
We've determined the correct timezone for timestamp conversions in the scheduler trigger tracing logs. Remove unnecessary information to make log easier to read.
Tests
Commits