[GOBBLIN-1929] add dataset root in some common type of datasets#3802
Merged
arjun4084346 merged 1 commit intoapache:masterfrom Oct 18, 2023
Merged
[GOBBLIN-1929] add dataset root in some common type of datasets#3802arjun4084346 merged 1 commit intoapache:masterfrom
arjun4084346 merged 1 commit intoapache:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3802 +/- ##
============================================
- Coverage 47.37% 47.33% -0.04%
- Complexity 10973 10976 +3
============================================
Files 2152 2152
Lines 85154 85179 +25
Branches 9470 9472 +2
============================================
- Hits 40341 40319 -22
- Misses 41155 41203 +48
+ Partials 3658 3657 -1 ☔ View full report in Codecov by Sentry. |
umustafi
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
This PR adds dataset path in IcebergDataset and RecursiveCopyableDataset , which is one of the most commonly used dataset type in distcp jobs. dataset path is needed by datasethandler to find the shard path.
JIRA
Description
This PR completes the work of https://github.com/apache/gobblin/pull/3799/files
Tests
trivial changes, tested manually
Commits