[GOBBLIN-2036] Fix type error where string config is forced into boolean type

[Will-Lo]

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

• My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
  • https://issues.apache.org/jira/browse/GOBBLIN-2036

Description

• Here are some details about my PR, including screenshots (if applicable):
  The old value of flow.allowConcurrentExecution is set as a string value in the flow configuration jsons, but in the code we parse it as boolean. Instead we want to parse as string then convert to boolean to make this backwards compatible with existing flow configs.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.64%. Comparing base (1fe2958) to head (fbd7ef4).

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #3915      +/-   ##
============================================
- Coverage     46.64%   46.64%   -0.01%     
- Complexity    11222    11224       +2     
============================================
  Files          2244     2244              
  Lines         88367    88368       +1     
  Branches       9679     9679              
============================================
- Hits          41221    41216       -5     
- Misses        43430    43441      +11     
+ Partials       3716     3711       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[umustafi]

This worked before because we had the value as a string? I don't recall us changing the configurations, but regardless of how flow.allowConcurrentExecution is set in the configs this always interprets it as a string then takes the boolean value of it correct?